Conversation
|
+1 It looks like the Travis tests are failing for this branch but passed the last time they were run several months ago. However, it looks like they exit entirely as soon as the server tests begin, which leads me to believe that the problem isn't with this code but rather because Travis has perhaps begin to be more strict about whether we're allowed to do stuff like have a socket open a TCP port and make connections to it. This leads me to believe that we could get our tests running again by changing this line If you feel like making and testing that change as part of this PR so that merging this doesn't break Travis then that would be great. If you don't want to hold up this PR since we have other stuff which depends on it, then I'd be okay with this getting merged in as-is and punting on getting Travis running again. |
The
jsonrpc_handlerwas created with the intent that it would be added as a member of a class, so it was given a single positional parameter namedself. This unfortunately breaks when thejsonrpc_handleris used outside the context of a class (it throws "missing requiredselfargument" errors).The
selfparameter is never actually referenced. This pull request switches the parameter fromselftoself=None, so thejsonrpc_handlerfunction can be invoked outside the context of a class.