config: workspace display order#542
Merged
Merged
Conversation
mahkoh
reviewed
Jul 26, 2025
mahkoh
reviewed
Jul 26, 2025
mahkoh
reviewed
Jul 26, 2025
mahkoh
reviewed
Jul 26, 2025
Owner
|
I think it would be better if the workspaces were sorted in the linked list. |
Contributor
Author
You mean keeping the list of workspaces sorted at all times when it's updated? |
Owner
|
Yes. |
Contributor
Author
|
Ignore the wip stuff, need to test this across different machines to figure out the workspace dragging and fix a couple of issues after the recent cleanup. |
7e83b5a to
283f4e0
Compare
Contributor
Author
|
Can you take a look? Needed to handle a bit more than I initially thought:
I tested all 3 cases and it seems to work ok. |
283f4e0 to
cf4f996
Compare
mahkoh
reviewed
Jul 26, 2025
mahkoh
reviewed
Jul 26, 2025
mahkoh
reviewed
Jul 26, 2025
cf4f996 to
a6dda1e
Compare
Contributor
Author
|
Addressed those points. Squashed the commits, noticed in other PRs you prefer it that way and I've done it like that before as well. |
mahkoh
reviewed
Jul 26, 2025
a6dda1e to
2e7368a
Compare
2e7368a to
e570152
Compare
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Point 1 from #519 done as we talked about here #541 (comment).