config: workspace empty behavior by kotarac · Pull Request #816 · mahkoh/jay

kotarac · 2026-03-19T17:54:02Z

Implementation according to our discussion here #541.
Closes #519.

mahkoh · 2026-03-28T15:01:35Z

In case you wrote the book changes by hand: You don't have to do that. There is already enough busy work when adding new features.

kotarac · 2026-03-28T15:19:31Z

In case you wrote the book changes by hand: You don't have to do that. There are already enough busy work when adding new features.

I did not actually. I've had gpt-5.2 write the book content and before that help me better clarify the behavior of each value in spec.yaml and review the changes. Or to be precise, review the changes and then do all that.

Btw, possibly interesting piece of info: I've tried letting it help write a testcase in the integration test and I ended up with a couple GiB worth of logs in testruns/ dir because it destroyed a wl_surface before destroying a wl_viewport, resulting in leak tracking going crazy with logging.

Still need to get around to testing this on multiple outputs. I only have such setup at the office and unfortunately I haven't had any time lately to sit down and go through it.

kotarac · 2026-03-28T15:26:19Z

In case you wrote the book changes by hand: You don't have to do that. There is already enough busy work when adding new features.

Also, fwiw, while this is true and the book and control center added more, I don't really mind this at all.

In my 1st Jay contribution on the touchpad stuff, it took quite some time to go through everything, but the 1st moment I've had it compile it actually worked correctly (despite having multiple style/consistency issues) which is at least partly because of the way it's set up right now.

I suppose some of it could be distilled now to somehow have 1 central place which dictates how all "touchpoints" work, but it's not exactly a big deal once you know where everything is.

mahkoh · 2026-04-11T11:31:15Z

If you only have one display you can manually test this using virtual outputs and wl-mirror or obs.

kotarac · 2026-04-11T11:33:38Z

If you only have one display you can manually test this using virtual outputs and wl-mirror or obs.

Got one now actually, just need to get around to it. Rebasing it to stay up to date as I'm dogfooding this. 🙂

kotarac · 2026-04-15T17:40:13Z

Needs a bit more work, couple of edge cases to go through and some more ext_workspace_manager_v1 work which has 0 test coverage and I don't usually use it.

mahkoh · 2026-05-04T20:57:21Z

Feature detection should only be used if not doing so would regress existing functionality.

kotarac · 2026-05-04T21:06:03Z

Otherwise, tested the non-protocol paths quite a bit myself and have ran this for longer than the PR has been up, although almost exclusively set to destroy while not testing the work itself.

For the protocol changes, I tested a bit with waybar (I don't usually use it), but not nearly as extensively as with the above.

kotarac · 2026-05-05T16:30:39Z

-.-

mahkoh

I feel like hidden workspaces should stay attached to their output. That would also remove the need to find the correct output when unhiding the workspace and would keep the workspace in the same position as before.

Sometimes it might be useful to have a linked list containing only the visible workspaces. For such cases it might be useful to maintain two linked lists per output. One containing all workspaces and one containing only the visible workspaces.

kotarac · 2026-05-05T18:04:09Z

I feel like hidden workspaces should stay attached to their output. That would also remove the need to find the correct output when unhiding the workspace and would keep the workspace in the same position as before.

Hmm, that would help. And yes, the current approach didn't place it back where it was in case the display order was manual.

Sometimes it might be useful to have a linked list containing only the visible workspaces. For such cases it might be useful to maintain two linked lists per output. One containing all workspaces and one containing only the visible workspaces.

👍

kotarac · 2026-05-05T20:55:20Z

Think the separate linked list only for visible workspaces is needed? Seems cheap to just filter out hidden ones where needed, but it is inconvenient that it's done in multiple places though...

kotarac · 2026-05-10T12:15:58Z

FTR since the last review, I discovered a small issue when destroy is set with floating windows, that's another extra change since.

kotarac · 2026-05-10T13:33:16Z

        mut output: Option<Rc<OutputNode>>,
    ) {
-        let mut output = || {
+        let mut resolve_output = || {


Might make sense to extract to a helper fn.

mahkoh · 2026-05-11T11:56:57Z

+        let Some(ws) = data.workspace.get() else {
+            return;
+        };
+        state.map_tiled_on(tl.clone(), &ws);
        parent.cnode_remove_child2(&*tl, true);
-        state.map_tiled(tl);
-    } else if let Some(ws) = data.workspace.get() {
-        parent.cnode_remove_child2(&*tl, true);
-        let (width, height) = data.float_size(&ws);
-        state.map_floating(tl, width, height, &ws, None);
+        return;
    }
+    let Some(ws) = data.workspace.get() else {
+        return;
+    };
+    let (width, height) = data.float_size(&ws);
+    state.map_floating(tl.clone(), width, height, &ws, None);
+    parent.cnode_remove_child2(&*tl, true);


What does this do?

#816 (comment)

Single window remaining on a workspace with empty behavior set to destroy being toggled between tiled/floating.

This seems to change the behavior of toggling a window from floating to tiled.

Will take a look ~wednesday. Right now, looking at this on the phone and answering by memory. 🙂

kotarac force-pushed the kotarac/workspace-empty-behavior branch 5 times, most recently from 67611a2 to 1e3dc69 Compare March 24, 2026 00:20

kotarac force-pushed the kotarac/workspace-empty-behavior branch 6 times, most recently from 8c2f2f8 to e370b81 Compare April 2, 2026 22:08

kotarac force-pushed the kotarac/workspace-empty-behavior branch 3 times, most recently from 7043ed0 to db0e415 Compare April 11, 2026 11:14

kotarac force-pushed the kotarac/workspace-empty-behavior branch 10 times, most recently from 35a7d00 to ef352af Compare May 3, 2026 20:58

kotarac force-pushed the kotarac/workspace-empty-behavior branch 2 times, most recently from aae8b65 to ca8fba2 Compare May 5, 2026 15:59

kotarac force-pushed the kotarac/workspace-empty-behavior branch from ca8fba2 to 3c8a4ef Compare May 5, 2026 16:30

mahkoh self-requested a review May 5, 2026 17:09

mahkoh requested changes May 5, 2026

View reviewed changes

kotarac force-pushed the kotarac/workspace-empty-behavior branch 2 times, most recently from bbb0d65 to ed761f7 Compare May 5, 2026 20:45

mahkoh reviewed May 7, 2026

View reviewed changes

Comment thread src/tree/output.rs Outdated

kotarac force-pushed the kotarac/workspace-empty-behavior branch 6 times, most recently from 11885e9 to 1aa5dd4 Compare May 10, 2026 09:20

mahkoh reviewed May 10, 2026

View reviewed changes

Comment thread src/state.rs Outdated

kotarac force-pushed the kotarac/workspace-empty-behavior branch 3 times, most recently from 54f85c1 to a17f1ab Compare May 10, 2026 13:16

kotarac commented May 10, 2026

View reviewed changes

kotarac force-pushed the kotarac/workspace-empty-behavior branch 2 times, most recently from f3f7fa2 to 612a896 Compare May 11, 2026 06:13

config: workspace empty behavior

3e34c6b

kotarac force-pushed the kotarac/workspace-empty-behavior branch from 612a896 to 3e34c6b Compare May 11, 2026 06:29

mahkoh reviewed May 11, 2026

View reviewed changes

Conversation

kotarac commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mahkoh commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kotarac commented Mar 28, 2026

Uh oh!

kotarac commented Mar 28, 2026

Uh oh!

mahkoh commented Apr 11, 2026

Uh oh!

kotarac commented Apr 11, 2026

Uh oh!

kotarac commented Apr 15, 2026

Uh oh!

mahkoh commented May 4, 2026

Uh oh!

kotarac commented May 4, 2026

Uh oh!

kotarac commented May 5, 2026

Uh oh!

mahkoh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kotarac commented May 5, 2026

Uh oh!

kotarac commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kotarac commented May 10, 2026

Uh oh!

kotarac May 10, 2026

Choose a reason for hiding this comment

Uh oh!

mahkoh May 11, 2026

Choose a reason for hiding this comment

Uh oh!

kotarac May 11, 2026

Choose a reason for hiding this comment

Uh oh!

mahkoh May 11, 2026

Choose a reason for hiding this comment

Uh oh!

kotarac May 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kotarac commented Mar 19, 2026 •

edited

Loading

mahkoh commented Mar 28, 2026 •

edited

Loading

kotarac commented May 5, 2026 •

edited

Loading