vulkan: use external_semaphore_drm_syncobj if available#943
Draft
mahkoh wants to merge 1 commit into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for using VK_EXT_external_semaphore_drm_syncobj for Vulkan timeline semaphore export when available, falling back to opaque FD export otherwise.
Changes:
- Detects DRM syncobj semaphore export support and enables the extension/feature during device creation.
- Adds
supports_syncobj_exportto Vulkan device abstractions. - Updates timeline semaphore creation to prefer DRM_SYNCOBJ_EXT handles.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/vulkan_core/timeline_semaphore.rs |
Prefers DRM_SYNCOBJ_EXT export for timeline semaphores when supported. |
src/vulkan_core/device.rs |
Extends the Vulkan device trait with syncobj export capability reporting. |
src/vulkan_core.rs |
Adds core capability detection for DRM syncobj semaphore export. |
src/gfx_apis/vulkan/device.rs |
Enables syncobj extension/feature for the main Vulkan renderer. |
src/egui_adapter/egui_vulkan.rs |
Enables syncobj extension/feature for the egui Vulkan renderer. |
src/copy_device.rs |
Enables syncobj extension/feature for copy devices. |
Cargo.toml |
Switches jay-ash to a git branch containing syncobj support. |
Cargo.lock |
Updates locked jay-ash dependency source/version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
002ef85 to
4052d97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KhronosGroup/Vulkan-Docs#2692