Skip to content

Launcher as a service#42

Merged
Viv-Rajkumar merged 61 commits into
maidsafe:masterfrom
ustulation:Launcher
Oct 6, 2015
Merged

Launcher as a service#42
Viv-Rajkumar merged 61 commits into
maidsafe:masterfrom
ustulation:Launcher

Conversation

@ustulation
Copy link
Copy Markdown
Contributor

Review on Reviewable

@Fraser999 Fraser999 self-assigned this Sep 24, 2015
Comment thread proposed/0006-Launcher.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To disambiguate it from the "Launcher-Simplified" RFC, this should be renamed to something like "Launcher as a service/daemon".

@Fraser999
Copy link
Copy Markdown
Contributor

The file name shouldn't contain the prospective RFC number. Also, it should be renamed to match whatever the updated "Feature Name" becomes.

Comment thread proposed/0006-Launcher.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs fleshed out a bit. It should still be a single paragraph, but it should allow third-party readers to get a rough idea of what the product will be, and this also should allow readers to disambiguate between the other proposed Launcher RFC.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start for an initial implementation to the RPCs. Might be worth considering some alternatives to the data section formats for the future too. say for example:

{
  endpoint: "safe-api/v1.4/nfs/create-dir"
  data: {
    is_shared: false,
    path: "/a/b/c"
    is_private: true
    ...
  }
}

@Viv-Rajkumar Viv-Rajkumar merged commit 3a802f6 into maidsafe:master Oct 6, 2015
@ustulation ustulation deleted the Launcher branch October 7, 2015 13:22
frabrunelle pushed a commit that referenced this pull request Sep 6, 2016
Not being worked on:
[#9 MPID Messaging System]
[#21 MPID Message Delete]

Not used:
[#20 Crust Refactor]

Replaced with RFC 41 & 42:
[#25 Launcher Direct Data API]
[#27 Append by all Structured Data Type]
[#28 Launcher Low Level API]

New active RFCs:
[#41 Low Level API]
[#42 SAFE Launcher API v0.6]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants