Add the PHP Compat GitHub Action Workflow #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkotter
force-pushed
the
feature/3-phpcompat-workflow
branch
from
e623866 to
ca54344
Compare
jeffpaul
reviewed
May 31, 2024
| <exclude-pattern>*/po/*</exclude-pattern> | ||
|
|
||
| <config name="minimum_supported_wp_version" value="6.0"/> | ||
| <config name="testVersion" value="7.4-"/> |
Collaborator
There was a problem hiding this comment.
I missed this in my review before merging, but perhaps this should bump down to 5.6 until #3 settles on the PHP min?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds in a new GitHub Action Workflow to run PHPCS Compatibility. We set our minimum PHP version to 7.4 and WordPress version to 6.0, but those can both be changed if we want to support older versions of things.
This Workflow is set to run anytime code is pushed to
developormain(and there are PHP files) or when a PR is opened againstdevelop(and there are PHP files).Solves one of the issues reported in #3 but there's remaining items, so this PR won't close out that Issue
How to test the Change
Ensure the PHP Compatibility Workflow ran when PHP files changed: https://github.com/mailchimp/wordpress/actions/runs/9310169175
Changelog Entry