Conversation
frankthrock
approved these changes
Oct 16, 2020
frankthrock
left a comment
frankthrock
left a comment
There was a problem hiding this comment.
Looks good. The examples are very clear.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Redesign
RubyGit::FileHelpers.whichso that ENV does not need to be manipulated in order to test. Instead of using ENV directly, add parameters for path and path_ext that default to ENV['PATH'] and ENV['PATHEXT'] respectively. These parameters can be overridden for testing.Tests were added to test
RubyGit::FileHelpers.whichdirectly.Since the interface for
RubyGit::FileHelpers.whichchanged,RubyGit::GitBinary.default_path(and it's tests) also had to be updated.What is changed?
RubyGit::FileHelpersand its tests.RubyGit::GitBinaryand its tests.What else was changed and why?
lib/ruby_git.rbandlib/ruby_git/worktree.rbminor documentation format changes.