Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As a user of the RubyGit gem
I want to be able to see what git commands are executed as I use the RubyGit gem
So that I can debug my use of the RubyGit gem
Add a centralized logger as an attribute to the
RubyGitmodule.Using the logger:
Setting the logger to capture log messages in an instance of
StringIO:By default,
RubyGit.loggershould be an instance ofNullLogger.What is changed?
ruby_git.gemspeclib/ruby_git.rbandlib/ruby_git_spec.rbloggerwhich defaults to an instance ofNullLogger.RubyGit.gitis documented so it shows up as a "Class Attribute" in the yard documentation to match howRubyGit.loggeris documented.lib/ruby_git/worktree.rbandlib/ruby_git/worktree_spec_initializeWorktreeinstances at debug level.What else was changed and why?