Conversation
jcouball
force-pushed
the
rename_worktree
branch
3 times, most recently
from
b165dfd to
532f80d
Compare
frankthrock
reviewed
Oct 18, 2020
lib/ruby_git.rb
Outdated
| end | ||
|
|
||
| # Create an empty Git repository under the root worktree `path` | ||
| # Create an empty Git repository under the root woring tree `path` |
frankthrock
reviewed
Oct 18, 2020
README.md
Outdated
| RubyGit is an object-oriented wrapper for the `git` command line tool for working with Worktrees | ||
| and Repositories. It tries to make more sense out of the Git command line. See the object model | ||
| in [this Lucid chart diagram](https://app.lucidchart.com/invitations/accept/7df13bab-3383-4683-8cb4-e76d539de93d) | ||
| RubyGit is an object-oriented wrapper for the `git` command line tool for working git Repositories. |
There was a problem hiding this comment.
Perhaps you want to add 'with' here? ...working WITH git repositories. (Up to you...)
jcouball
force-pushed
the
rename_worktree
branch
2 times, most recently
from
db7abac to
3460f37
Compare
jcouball
force-pushed
the
rename_worktree
branch
from
3460f37 to
ed8b21c
Compare
Member
Author
|
Thanks, @frankthrock for the review. I have fixed the issues you pointed out and added the following:
|
frankthrock
approved these changes
Oct 19, 2020
frankthrock
left a comment
frankthrock
left a comment
There was a problem hiding this comment.
Looks really good. I like the verbose changes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename the
Worktreeclass toWorkingTreeto be more consistent with Git documentation and the term's use in public.See the definition of Working Tree in the Git glossary or search the web for Git working tree.
What is changed?
All code and documentation that referred to worktree was changed to working tree.
What else was changed and why?