Skip to content

Use GitHub Actions for CI Builds#29

Merged
jcouball merged 6 commits intomainfrom
github_action
Nov 6, 2020
Merged

Use GitHub Actions for CI Builds#29
jcouball merged 6 commits intomainfrom
github_action

Conversation

@jcouball
Copy link
Member

@jcouball jcouball commented Nov 5, 2020

Description

Travis builds can take an hour to start because they limit open source builds so much. See if GitHub Actions can provide the same functionality with faster feedback.

What is changed?

  • The GitHub Action is defined in .github/workflows/ruby.yml. It sets up Ruby, installs dependencies, and then runs the default rake task.
  • Removed .travis.yml
  • Replace link to build in README.md to point to the GitHub action

What else was changed and why?

  • New Rubocop offenses had to be fixed in spec/lib/ruby_git/file_helpers_spec.rb
  • Moved the following GitHub specific files from the project root to the .github directory: CODEOWNERS, ISSUE_TEMPLATE.md, and PULL_REQUEST_TEMPLATE.md

@jcouball jcouball requested a review from a team as a code owner November 5, 2020 18:30
@jcouball jcouball changed the title GitHub action Use GitHub Actions for CI Builds Nov 5, 2020
Copy link

@frankthrock frankthrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, provided that the CI passes.

@jcouball jcouball merged commit efa2c90 into main Nov 6, 2020
@jcouball jcouball deleted the github_action branch November 6, 2020 22:00
@jcouball jcouball mentioned this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants