Skip to content

Do not enforce coverage threshold for RSpec dry run#30

Merged
jcouball merged 1 commit intomainfrom
vscode_changes
Nov 10, 2020
Merged

Do not enforce coverage threshold for RSpec dry run#30
jcouball merged 1 commit intomainfrom
vscode_changes

Conversation

@jcouball
Copy link
Member

@jcouball jcouball commented Nov 6, 2020

Description

Changes to support using Visual Studio Code / GitHub Codespaces

What is changed?

  • The Visual Studio Code Rspec Test Explorer extension runs rspec --dry-run in order to list the available tests. In this PR, a change was made to spec/spec_helper.rb to NOT make an RSpec dry run fail when code coverage is lower than the configured amount.

What else was changed and why?

  • Nothing

@jcouball jcouball requested a review from a team as a code owner November 6, 2020 22:14
@jcouball jcouball changed the title vscode_changes Visual Studio Code Changes Nov 6, 2020
frankthrock
frankthrock previously approved these changes Nov 6, 2020
Copy link

@frankthrock frankthrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jcouball jcouball changed the title Visual Studio Code Changes Allow rspec --dry-run to succeed when coverage is below threshold Nov 10, 2020
@jcouball jcouball changed the title Allow rspec --dry-run to succeed when coverage is below threshold Do not enforce coverage threshold in an RSpec dry run Nov 10, 2020
@jcouball jcouball changed the title Do not enforce coverage threshold in an RSpec dry run Do not enforce coverage threshold for RSpec dry run Nov 10, 2020
Copy link

@frankthrock frankthrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@jcouball jcouball merged commit 359c358 into main Nov 10, 2020
@jcouball jcouball deleted the vscode_changes branch November 10, 2020 19:23
@jcouball jcouball mentioned this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants