NOISSUE - Add dynamic prefix conf, and authentication when behind proxy. #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuio
reviewed
Nov 16, 2021
|
|
||
| import { STRINGS } from 'assets/text/strings'; | ||
|
|
||
| import { environment } from '../../../../environments/environment'; |
Contributor
There was a problem hiding this comment.
environments/environment is ok here
Contributor
There was a problem hiding this comment.
Find a solution please. As you can see we are using absolute path everywhere. For example import { UsersService } from 'app/common/services/users/users.service';
manuio
reviewed
Nov 16, 2021
manuio
requested changes
Nov 16, 2021
mteodor
changed the title
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
manuio
requested changes
Nov 18, 2021
manuio
reviewed
Nov 18, 2021
manuio
requested changes
Nov 18, 2021
manuio
requested changes
Nov 19, 2021
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
manuio
requested changes
Nov 25, 2021
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
blokovi
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mteodor mirko.teodorovic@gmail.com
When deploying with other applications it may be neccessary to avoid clashing of paths so it may be useful to configure
prefixfor the whole UI appso for MF_UI_APP_PREFIX='app' urls like
/auth/loginbecome/app/auth/login