Adapt a build/addons-based file structure#41
Open
Ivorforce wants to merge 1 commit intomaiself:masterfrom
Open
Adapt a build/addons-based file structure#41Ivorforce wants to merge 1 commit intomaiself:masterfrom
Ivorforce wants to merge 1 commit intomaiself:masterfrom
Conversation
Ivorforce
force-pushed
the
releasable-builds
branch
3 times, most recently
from
72c00d4 to
72a3071
Compare
…e for direct deployment, and prevents multiple binaries from being loaded in test if multiple subsequent builds are made.
Ivorforce
force-pushed
the
releasable-builds
branch
from
72a3071 to
b03497b
Compare
maiself
added
enhancement
Owner
|
Will take a closer look later and do some testing, but I like the result and direction this is taking things. 👍 |
Contributor
|
@maiself How did the review go? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes releases suitable for direct deployment (check the binaries from the build action).
With relative paths, the addon is now also agnostic to where it ends up in the godot project. Also, the windows binary is renamed to omit the 'lib' prefix, which is nonstandard in windows (as indicated by
$SHLIBPREFIX).This is (roughly) the file structure I also use in NumDot.