Skip to content

Conversation

@Sploder12
Copy link
Member

@Sploder12 Sploder12 commented Apr 21, 2023

Description

Provides a way to interact with page tables and directories.
Also identity maps the first 12MiB.
Note: does not do allocation or anything that requires it. Intended for separate PR

Issue #28

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)

Testing

Existing tests all pass.
In addition, tests were added to verify the identity paging is valid.
And for translation of virtual address to physical address.
And for swapping the active page directory.

Test Configuration:

  • qemu 7.2.0 on Windows 10 with WSL 5.10.16.3 running Ubuntu 20.04
  • python 3.10.10

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@emilkovacev
Copy link
Member

I'm glad I waited a bit longer to make a review, the docs look excellent! I'll try to get a review out today, maybe before our meeting, but no promises

Copy link
Member

@bicknrown bicknrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall quite thorough, as far as i can tell, just some minor formatting/linting things and i'll be happy.
thank you for your effort!

@bicknrown
Copy link
Member

the branch is also out of date with main, so i would see if that doesn't break anything either.

@Sploder12 Sploder12 requested a review from bicknrown September 10, 2023 16:55
Copy link
Member

@emilkovacev emilkovacev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb documentation and commenting! I have but a few small suggestions – the tests run smoothly and qemu still runs well after these changes.

Copy link
Member

@emilkovacev emilkovacev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything appears to be in order!

@Sploder12 Sploder12 dismissed bicknrown’s stale review September 13, 2023 04:04

Requested minor (non functionality changes). No response since June. Approved by others.

@emilkovacev emilkovacev mentioned this pull request Feb 12, 2024
6 tasks
gcc makes things so difficult
@Real-Septicake
Copy link
Collaborator

LGTM!

@Real-Septicake Real-Septicake merged commit 0ab7284 into makeopensource:main Mar 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants