This repository was archived by the owner on Nov 20, 2024. It is now read-only.
Add - to domain part of regex for email#151
Open
TheZoker wants to merge 1 commit intomakeplane:developfrom
Open
Add - to domain part of regex for email#151TheZoker wants to merge 1 commit intomakeplane:developfrom
- to domain part of regex for email#151TheZoker wants to merge 1 commit intomakeplane:developfrom
Conversation
Contributor
Author
|
@rameshkumarchandra Can you please have a look at this small PR? Thanks! |
|
domain part may contain multiple segments. ie. mycorp.co.uk or mail.tla.gov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to have a
-in the domain part of the email. I'm still not sure if this regex is the best way to test for emails. Maybe there are other emails that are not covered by this.