Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

fix: Editor url, some index issues, project view json parsing issue#88

Open
yahu1031 wants to merge 1 commit intomakeplane:developfrom
yahu1031:issue-editor-fix
Open

fix: Editor url, some index issues, project view json parsing issue#88
yahu1031 wants to merge 1 commit intomakeplane:developfrom
yahu1031:issue-editor-fix

Conversation

@yahu1031
Copy link

@yahu1031 yahu1031 commented Sep 14, 2023 •
edited
Loading

  1. The editor url path was wrong which appends m in the domain.
  2. Index issues where they overflows due to the the length wasn't matching to assign the context to the provider.
  3. JSON parsing to the display_filters and display_properties wasn't correct where it likely breaks the app.(Tested and verified.)
  4. disabling the chatbot accessibility in the editor.(Mentioned in the comments)

Likely fixes #81

yahu1031
yahu1031 commented Sep 14, 2023
View reviewed changes
lib/utils/editor.dart
onLoadStop: (controller, url) {
// This is to remove the default crisp chatbot from the editor
// as it is not needed in the editor
controller.evaluateJavascript(
Copy link
Author

@yahu1031 yahu1031 Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: App crashes while adding description

1 participant

@yahu1031