Skip to content

chore: increase project identifier max length to 12 #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NarayanBavisetti merged 1 commit into from
Jul 24, 2023
Merged

chore: increase project identifier max length to 12 #1638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions apps/app/components/project/create-project-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ export const CreateProjectModal: React.FC<Props> = ({ isOpen, setIsOpen, user })
setValue,
} = useForm<IProject>({
defaultValues,
mode: "all",
reValidateMode: "onChange",
});

Expand Down Expand Up @@ -298,8 +297,8 @@ export const CreateProjectModal: React.FC<Props> = ({ isOpen, setIsOpen, user })
message: "Identifier must at least be of 1 character",
},
maxLength: {
value: 5,
message: "Identifier must at most be of 5 characters",
value: 12,
message: "Identifier must at most be of 12 characters",
},
}}
/>
Expand Down
2 changes: 1 addition & 1 deletion apps/app/components/ui/dropdowns/custom-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const CustomMenu = ({
{({ open }) => (
<>
{customButton ? (
<Menu.Button as="button" onClick={menuButtonOnClick}>
<Menu.Button as="button" type="button" onClick={menuButtonOnClick}>
{customButton}
</Menu.Button>
) : (
Expand Down
1 change: 1 addition & 0 deletions apps/app/components/ui/dropdowns/custom-search-select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ export const CustomSearchSelect = ({
<Combobox.Button as="div">{customButton}</Combobox.Button>
) : (
<Combobox.Button
type="button"
className={`flex items-center justify-between gap-1 w-full rounded-md shadow-sm border border-custom-border-300 duration-300 focus:outline-none ${
input ? "px-3 py-2 text-sm" : "px-2.5 py-1 text-xs"
} ${
Expand Down
1 change: 1 addition & 0 deletions apps/app/components/ui/dropdowns/custom-select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ const CustomSelect = ({
<Listbox.Button as="div">{customButton}</Listbox.Button>
) : (
<Listbox.Button
type="button"
className={`flex items-center justify-between gap-1 w-full rounded-md border border-custom-border-300 shadow-sm duration-300 focus:outline-none ${
input ? "px-3 py-2 text-sm" : "px-2.5 py-1 text-xs"
} ${
Expand Down