Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apiserver/plane/api/serializers/project.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ class ProjectDetailSerializer(BaseSerializer):
total_cycles = serializers.IntegerField(read_only=True)
total_modules = serializers.IntegerField(read_only=True)
is_member = serializers.BooleanField(read_only=True)
sort_order = serializers.FloatField(read_only=True)

class Meta:
model = Project
Expand Down
27 changes: 22 additions & 5 deletions apiserver/plane/api/views/project.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# Django imports
from django.core.exceptions import ValidationError
from django.db import IntegrityError
from django.db.models import Q, Exists, OuterRef, Func, F
from django.db.models import Q, Exists, OuterRef, Func, F, Min, Subquery
from django.core.validators import validate_email
from django.conf import settings

Expand Down Expand Up @@ -120,9 +120,15 @@ def list(self, request, slug):
project_id=OuterRef("pk"),
workspace__slug=self.kwargs.get("slug"),
)
sort_order_query = ProjectMember.objects.filter(
member=request.user,
project_id=OuterRef("pk"),
workspace__slug=self.kwargs.get("slug"),
).values("sort_order")
projects = (
self.get_queryset()
.annotate(is_favorite=Exists(subquery))
.annotate(sort_order=Subquery(sort_order_query))
.order_by("sort_order", "name")
.annotate(
total_members=ProjectMember.objects.filter(
Expand Down Expand Up @@ -592,17 +598,26 @@ def post(self, request, slug, project_id):
{"error": "Atleast one member is required"},
status=status.HTTP_400_BAD_REQUEST,
)
bulk_project_members = []

project_members = ProjectMember.objects.bulk_create(
[
project_members = ProjectMember.objects.filter(
workspace=self.workspace, member_id__in=[member.get("member_id") for member in members]
).values("member_id").annotate(sort_order_min=Min("sort_order"))

for member in members:
sort_order = [project_member.get("sort_order") for project_member in project_members]
bulk_project_members.append(
ProjectMember(
member_id=member.get("member_id"),
role=member.get("role", 10),
project_id=project_id,
workspace_id=project.workspace_id,
sort_order=sort_order[0] - 10000 if len(sort_order) else 65535
)
for member in members
],
)

project_members = ProjectMember.objects.bulk_create(
bulk_project_members,
batch_size=10,
ignore_conflicts=True,
)
Expand Down Expand Up @@ -845,12 +860,14 @@ def post(self, request, slug, project_id):
view_props = project_member.view_props
default_props = project_member.default_props
preferences = project_member.preferences
sort_order = project_member.sort_order

project_member.view_props = request.data.get("view_props", view_props)
project_member.default_props = request.data.get(
"default_props", default_props
)
project_member.preferences = request.data.get("preferences", preferences)
project_member.sort_order = request.data.get("sort_order", sort_order)

project_member.save()

Expand Down
12 changes: 6 additions & 6 deletions apiserver/plane/db/migrations/0039_auto_20230723_2203.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,16 +58,16 @@ def update_workspace_member_props(apps, schema_editor):
Model.objects.bulk_update(updated_workspace_member, ["view_props"], batch_size=100)


def update_project_sort_order(apps, schema_editor):
Model = apps.get_model("db", "Project")
def update_project_member_sort_order(apps, schema_editor):
Model = apps.get_model("db", "ProjectMember")

updated_projects = []
updated_project_members = []

for obj in Model.objects.all():
obj.sort_order = random.randint(1, 65536)
updated_projects.append(obj)
updated_project_members.append(obj)

Model.objects.bulk_update(updated_projects, ["sort_order"], batch_size=100)
Model.objects.bulk_update(updated_project_members, ["sort_order"], batch_size=100)


class Migration(migrations.Migration):
Expand All @@ -93,5 +93,5 @@ class Migration(migrations.Migration):
name='sort_order',
field=models.FloatField(default=65535),
),
migrations.RunPython(update_project_sort_order),
migrations.RunPython(update_project_member_sort_order),
]
15 changes: 14 additions & 1 deletion apiserver/plane/db/models/project.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ class Project(BaseModel):
default_state = models.ForeignKey(
"db.State", on_delete=models.SET_NULL, null=True, related_name="default_state"
)
sort_order = models.FloatField(default=65535)

def __str__(self):
"""Return name of the project"""
Expand Down Expand Up @@ -156,6 +155,20 @@ class ProjectMember(ProjectBaseModel):
view_props = models.JSONField(default=get_default_props)
default_props = models.JSONField(default=get_default_props)
preferences = models.JSONField(default=get_default_preferences)
sort_order = models.FloatField(default=65535)


def save(self, *args, **kwargs):
if self._state.adding:
smallest_sort_order = ProjectMember.objects.filter(
workspace=self.workspace, member=self.member
).aggregate(smallest=models.Min("sort_order"))["smallest"]

# Project ordering
if smallest_sort_order is not None:
self.sort_order = smallest_sort_order - 10000

super(ProjectMember, self).save(*args, **kwargs)

class Meta:
unique_together = ["project", "member"]
Expand Down