Skip to content

refactor: if/else conditions #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sriramveeraghanta merged 3 commits into from
Aug 10, 2023
Merged

refactor: if/else conditions #1822

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e91e68d
refactor: shortcuts if/else
dakshesh14 Aug 4, 2023
12e65da
fix: merge conflict
dakshesh14 Aug 9, 2023
0cb9bba
fix: merge conflict
dakshesh14 Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 25 additions & 24 deletions apps/app/components/command-palette/command-pallette.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,38 +78,39 @@ export const CommandPalette: React.FC = () => {

const handleKeyDown = useCallback(
(e: KeyboardEvent) => {
const singleShortcutKeys = ["p", "v", "d", "h", "q", "m"];
// if on input, textarea or editor, don't do anything
if (
e.target instanceof HTMLTextAreaElement ||
e.target instanceof HTMLInputElement ||
(e.target as Element).classList?.contains("remirror-editor")
)
return;

const { key, ctrlKey, metaKey, altKey, shiftKey } = e;

if (!key) return;

const keyPressed = key.toLowerCase();
if (
!(e.target instanceof HTMLTextAreaElement) &&
!(e.target instanceof HTMLInputElement) &&
!(e.target as Element).classList?.contains("remirror-editor")
) {
if ((ctrlKey || metaKey) && keyPressed === "k") {

const cmdClicked = ctrlKey || metaKey;

if (cmdClicked) {
if (keyPressed === "k") {
e.preventDefault();
setIsPaletteOpen(true);
} else if ((ctrlKey || metaKey) && keyPressed === "c") {
if (altKey) {
e.preventDefault();
copyIssueUrlToClipboard();
}
} else if (keyPressed === "c") {
} else if (keyPressed === "c" && altKey) {
e.preventDefault();
setIsIssueModalOpen(true);
} else if ((ctrlKey || metaKey) && keyPressed === "b") {
copyIssueUrlToClipboard();
} else if (keyPressed === "b") {
e.preventDefault();
// toggleCollapsed();
store.theme.setSidebarCollapsed(!store?.theme?.sidebarCollapsed);
} else if (key === "Delete") {
toggleCollapsed();
} else if (keyPressed === "backspace") {
e.preventDefault();
setIsBulkDeleteIssuesModalOpen(true);
} else if (
singleShortcutKeys.includes(keyPressed) &&
(ctrlKey || metaKey || altKey || shiftKey)
) {
e.preventDefault();
}
} else {
if (keyPressed === "c") {
setIsIssueModalOpen(true);
} else if (keyPressed === "p") {
setIsProjectModalOpen(true);
} else if (keyPressed === "v") {
Expand All @@ -125,7 +126,7 @@ export const CommandPalette: React.FC = () => {
}
}
},
[copyIssueUrlToClipboard]
[copyIssueUrlToClipboard, toggleCollapsed]
);

useEffect(() => {
Expand Down