Skip to content

refactor: added validation for display_name #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sriramveeraghanta merged 1 commit into from
Aug 10, 2023
Merged

refactor: added validation for display_name #1823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions apps/app/pages/[workspaceSlug]/me/profile/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,6 @@ const Profile: NextPage = () => {
<div className="grid grid-cols-12 gap-4 sm:gap-16">
<div className="col-span-12 sm:col-span-6">
<h4 className="text-lg font-semibold text-custom-text-100">Full Name</h4>
<p className="text-sm text-custom-text-200">
This name will be reflected on all the projects you are working on.
</p>
</div>
<div className="col-span-12 flex items-center gap-2 sm:col-span-6">
<Input
Expand All @@ -232,7 +229,8 @@ const Profile: NextPage = () => {
<div className="col-span-12 sm:col-span-6">
<h4 className="text-lg font-semibold text-custom-text-100">Display Name</h4>
<p className="text-sm text-custom-text-200">
The email address that you are using.
This could be your first name, or a nickname — however you{"'"}d like people to
refer to you in Plane.
</p>
</div>
<div className="col-span-12 sm:col-span-6">
Expand All @@ -246,13 +244,19 @@ const Profile: NextPage = () => {
placeholder="Enter your display name"
validations={{
required: "Display name is required.",
minLength: {
value: 3,
message: "Display name must be at least 3 characters long.",
},
maxLength: {
value: 20,
message: "Display name should not exceed 20 characters",
validate: (value) => {
if (value.trim().length < 1) return "Display name can't be empty.";

if (value.split(" ").length > 1)
return "Display name can't have two consecutive spaces.";

if (value.replace(/\s/g, "").length < 1)
return "Display name must be at least 1 characters long.";

if (value.replace(/\s/g, "").length > 20)
return "Display name must be less than 20 characters long.";

return true;
},
}}
/>
Expand Down