fix: context menu dynamic positioning, multiple context menus opening issue#1913
Merged
sriramveeraghanta merged 2 commits intodevelopfrom Aug 19, 2023
Merged
fix: context menu dynamic positioning, multiple context menus opening issue#1913sriramveeraghanta merged 2 commits intodevelopfrom
sriramveeraghanta merged 2 commits intodevelopfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
aaryan610
changed the title
sriramveeraghanta
approved these changes
Aug 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Fixed multiple context menus opening on the right click
Before the fix-
Plane._.Simple.extensible.open-source.project.management.tool.and.5.more.pages.-.Personal.-.Microsoft.Edge.2023-08-19.00-33-11.mp4
After the fix-
Plane._.Simple.extensible.open-source.project.management.tool.and.6.more.pages.-.Personal.-.Microsoft.Edge.2023-08-19.00-44-46.mp4
2. Fixed context menu hiding if there's not enough space to render
Other fixes-
useOutsideClickDetectorhook to call the callback function onmousedowninstead ofclick.