Skip to content

chore: reaction serializers #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablohashescobar merged 2 commits into from
Sep 1, 2023
Merged

chore: reaction serializers #2046

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20a1479
dev: chore reaction serializers
pablohashescobar Sep 1, 2023
046b655
fix: remove issue reaction lite serializer
pablohashescobar Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions apiserver/plane/api/serializers/issue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,9 @@ class Meta:


class IssueReactionSerializer(BaseSerializer):

actor_detail = UserLiteSerializer(read_only=True, source="actor")

class Meta:
model = IssueReaction
fields = "__all__"
Expand All @@ -525,19 +528,6 @@ class Meta:
]


class IssueReactionLiteSerializer(BaseSerializer):
actor_detail = UserLiteSerializer(read_only=True, source="actor")

class Meta:
model = IssueReaction
fields = [
"id",
"reaction",
"issue",
"actor_detail",
]


class CommentReactionLiteSerializer(BaseSerializer):
actor_detail = UserLiteSerializer(read_only=True, source="actor")

Expand Down Expand Up @@ -633,7 +623,7 @@ class IssueSerializer(BaseSerializer):
issue_link = IssueLinkSerializer(read_only=True, many=True)
issue_attachment = IssueAttachmentSerializer(read_only=True, many=True)
sub_issues_count = serializers.IntegerField(read_only=True)
issue_reactions = IssueReactionLiteSerializer(read_only=True, many=True)
issue_reactions = IssueReactionSerializer(read_only=True, many=True)

class Meta:
model = Issue
Expand All @@ -659,7 +649,7 @@ class IssueLiteSerializer(BaseSerializer):
module_id = serializers.UUIDField(read_only=True)
attachment_count = serializers.IntegerField(read_only=True)
link_count = serializers.IntegerField(read_only=True)
issue_reactions = IssueReactionLiteSerializer(read_only=True, many=True)
issue_reactions = IssueReactionSerializer(read_only=True, many=True)

class Meta:
model = Issue
Expand All @@ -680,7 +670,7 @@ class Meta:
class IssuePublicSerializer(BaseSerializer):
project_detail = ProjectLiteSerializer(read_only=True, source="project")
state_detail = StateLiteSerializer(read_only=True, source="state")
reactions = IssueReactionLiteSerializer(read_only=True, many=True, source="issue_reactions")
reactions = IssueReactionSerializer(read_only=True, many=True, source="issue_reactions")
votes = IssueVoteSerializer(read_only=True, many=True)

class Meta:
Expand Down