fix: Improved Image Deletion Logic, Image ID Issue in Modals and Performance Optimization in Editor#2092
Merged
sriramveeraghanta merged 4 commits intodevelopfrom Sep 7, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Ignored Deployments
|
Palanikannan1437
added
🐛bug
Palanikannan1437
force-pushed
the
multiple-image-modal
branch
from
346060b to
0e5f82b
Compare
sriramveeraghanta
approved these changes
Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Here I focus on resolving three issues:
The changes proposed significantly improve the time complexity of checking if a node still exists in the new state, from O(n) to O(1).
Background
The original S3 image deletion logic involved a complex process that included iterating through all nodes in the old state, checking for image nodes, and then traversing the entire new state for each node in the old state. This process was not only complex but also inefficient with a time complexity of O(n). Moreover, issues were encountered with image IDs changing randomly between two transactions in modals.
Solution
The solution implemented:
Demo
modal.issue.mov
Additional stuff
Solved a regression issue with Code blocks support with Syntax highlighting.