Skip to content

chore: response status for project views update #2111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sriramveeraghanta merged 2 commits into from
Sep 7, 2023
Merged

chore: response status for project views update #2111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9deccc6
chore: response status for project views update
pablohashescobar Sep 6, 2023
170e578
dev: remove 200 OK response from empty contents
pablohashescobar Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions apiserver/plane/api/views/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ def create(self, request):
# Delete joined project invites
project_invitations.delete()

return Response(status=status.HTTP_200_OK)
return Response(status=status.HTTP_204_NO_CONTENT)
except Exception as e:
capture_exception(e)
return Response(
Expand Down Expand Up @@ -924,8 +924,7 @@ def post(self, request, slug, project_id):

project_member.save()

return Response(status=status.HTTP_200_OK)

return Response(status=status.HTTP_204_NO_CONTENT)
except Project.DoesNotExist:
return Response(
{"error": "The requested resource does not exists"},
Expand Down
4 changes: 2 additions & 2 deletions apiserver/plane/api/views/workspace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ def create(self, request):
# Delete joined workspace invites
workspace_invitations.delete()

return Response(status=status.HTTP_200_OK)
return Response(status=status.HTTP_204_NO_CONTENT)
except Exception as e:
capture_exception(e)
return Response(
Expand Down Expand Up @@ -846,7 +846,7 @@ def post(self, request, slug):
workspace_member.view_props = request.data.get("view_props", {})
workspace_member.save()

return Response(status=status.HTTP_200_OK)
return Response(status=status.HTTP_204_NO_CONTENT)
except WorkspaceMember.DoesNotExist:
return Response(
{"error": "User not a member of workspace"},
Expand Down