Skip to content

refactor: switched priority null -> 'none' #2166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sriramveeraghanta merged 2 commits into from
Sep 13, 2023
Merged

refactor: switched priority null -> 'none' #2166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6207649
refactor: switched priority null -> 'none'
dakshesh14 Sep 13, 2023
10c83e0
Merge branch 'develop' of https://github.com/makeplane/plane into ref…
dakshesh14 Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/components/issues/form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const defaultValues: Partial<IIssue> = {
estimate_point: null,
state: "",
parent: null,
priority: null,
priority: "none",
assignees: [],
assignees_list: [],
labels: [],
Expand Down
2 changes: 1 addition & 1 deletion web/components/issues/select/priority.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const IssuePrioritySelect: React.FC<Props> = ({ value, onChange }) => (
<span>
<PriorityIcon priority={priority} />
</span>
<span className="capitalize">{priority ?? "None"}</span>
<span className="capitalize">{priority}</span>
</div>
</div>
</CustomSelect.Option>
Expand Down
2 changes: 1 addition & 1 deletion web/components/web-view/select-priority.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export const PrioritySelect: React.FC<Props> = (props) => {
<WebViewModal.Options
options={
PRIORITIES?.map((priority) => ({
label: priority ? capitalizeFirstLetter(priority) : "None",
label: capitalizeFirstLetter(priority),
value: priority,
checked: priority === value,
onClick: () => {
Expand Down
2 changes: 1 addition & 1 deletion web/constants/project.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const GROUP_CHOICES = {
cancelled: "Cancelled",
};

export const PRIORITIES: TIssuePriorities[] = ["urgent", "high", "medium", "low", null];
export const PRIORITIES: TIssuePriorities[] = ["urgent", "high", "medium", "low", "none"];

export const MONTHS = [
"January",
Expand Down
2 changes: 1 addition & 1 deletion web/types/issues.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,4 +248,4 @@ export interface IIssueViewProps {
properties: Properties;
}

export type TIssuePriorities = "urgent" | "high" | "medium" | "low" | null;
export type TIssuePriorities = "urgent" | "high" | "medium" | "low" | "none";