Skip to content

chore: kanban card state name and its dropdown text overflow #2686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sriramveeraghanta merged 1 commit into from
Nov 7, 2023
Merged

chore: kanban card state name and its dropdown text overflow #2686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions web/components/issues/issue-layouts/properties/state.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ export const IssuePropertyState: React.FC<IIssuePropertyState> = observer((props
value: state.id,
query: state.name,
content: (
<div className="flex items-center gap-2">
<div className="flex items-center gap-2 w-full overflow-hidden">
<StateGroupIcon stateGroup={state.group} color={state.color} />
{state.name}
<div className="truncate inline-block line-clamp-1 w-full">{state.name}</div>
</div>
),
}));
Expand All @@ -94,7 +94,7 @@ export const IssuePropertyState: React.FC<IIssuePropertyState> = observer((props
<Tooltip tooltipHeading="State" tooltipContent={value?.name ?? ""} position="top">
<div className="flex items-center cursor-pointer w-full gap-2 text-custom-text-200">
{value && <StateGroupIcon stateGroup={value.group} color={value.color} />}
<span className="truncate">{value?.name ?? "State"}</span>
<span className="truncate line-clamp-1 inline-block">{value?.name ?? "State"}</span>
</div>
</Tooltip>
);
Expand All @@ -104,7 +104,7 @@ export const IssuePropertyState: React.FC<IIssuePropertyState> = observer((props
{workspaceSlug && projectId && (
<Combobox
as="div"
className={`flex-shrink-0 text-left ${className}`}
className={`flex-shrink-0 text-left w-auto max-w-full ${className}`}
value={value.id}
onChange={(data: string) => {
const selectedState = projectStates?.find((state) => state.id === data);
Expand Down Expand Up @@ -159,7 +159,11 @@ export const IssuePropertyState: React.FC<IIssuePropertyState> = observer((props
{({ selected }) => (
<>
{option.content}
{selected && <Check className="h-3.5 w-3.5" />}
{selected && (
<div className="flex-shrink-0">
<Check className="h-3.5 w-3.5" />
</div>
)}
</>
)}
</Combobox.Option>
Expand Down
4 changes: 0 additions & 4 deletions web/components/issues/issue-layouts/roots/project-layout-root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,6 @@ export const ProjectLayoutRoot: React.FC = observer(() => {
}
);

console.log("--");
console.log("isLoading -- -->", isLoading);
console.log("--");

const activeLayout = issueFilterStore.userDisplayFilters.layout;

const issueCount = issueStore.getIssuesCount;
Expand Down