Skip to content

chore: drop-downs improvements and bug fixes#3433

Merged
sriramveeraghanta merged 8 commits intodevelopfrom
refactor/dropdowns
Jan 23, 2024
Merged

chore: drop-downs improvements and bug fixes#3433
sriramveeraghanta merged 8 commits intodevelopfrom
refactor/dropdowns

Conversation

@aaryan610
Copy link
Copy Markdown
Member

@aaryan610 aaryan610 commented Jan 23, 2024

This PR includes bug fixes and improvements on drop-downs

Bug fixes:

  1. Single select drop-downs not getting closed on selecting an option.
  2. External classNames from props not overwriting existing classNames.
  3. Drop-downs not getting auto-positioned in the list layout.

Improvements and Refactoring:

  1. Created one common type for dropdown props.
export type TDropdownProps = {
  buttonClassName?: string;
  buttonContainerClassName?: string;
  buttonVariant: TButtonVariants;
  className?: string;
  disabled?: boolean;
  placement?: Placement;
  tabIndex?: number;
};
  1. Updated the UI of the custom global drop-downs, including-

    • Custom menu.
    • Custom select.
    • Custom search select.
  2. Replaced string interpolation for classNames with cn helper function.

  3. Removed unnecessary props from custom global drop-downs.

@aaryan610 aaryan610 added this to the v0.15-dev milestone Jan 23, 2024
@aaryan610 aaryan610 changed the title Refactor/dropdowns chore: drop-downs improvements and bug fixes Jan 23, 2024
@aaryan610 aaryan610 marked this pull request as draft January 23, 2024 07:49
@aaryan610 aaryan610 marked this pull request as ready for review January 23, 2024 08:32
@sriramveeraghanta sriramveeraghanta merged commit 801f75f into develop Jan 23, 2024
@sriramveeraghanta sriramveeraghanta deleted the refactor/dropdowns branch January 23, 2024 08:55
vamsikrishnamathala pushed a commit that referenced this pull request Aug 7, 2025
* fix: circular dependencies and build issues (#7232)

* fix: circular dependencies and build issues
* chore: removed duplicate enums

* fix: build errors

* chore: minor fix

* fix: fixing circular dependecies and import errors

* fix: circular dependencies and pnpm builds (#3433)

* fix: circular dependencies and build issues

* fix: dependencies update

* fix: build

* chore: update all imports in types package

* chore: update enum imports

* chore: minor fixes

* fix: build errors

---------

Co-authored-by: Aaron Reisman <aaron.reisman@plane.so>

* fix: build errors

* chore: remove share page enum from constants

* fix: docker build

---------

Co-authored-by: Prateek Shourya <prateekshourya29@gmail.com>
Co-authored-by: Aaron Reisman <aaron.reisman@plane.so>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants