[WEB-1920] fix: project intake disabled validation#5161
Merged
sriramveeraghanta merged 1 commit intopreviewfrom Jul 18, 2024
Merged
[WEB-1920] fix: project intake disabled validation#5161sriramveeraghanta merged 1 commit intopreviewfrom
sriramveeraghanta merged 1 commit intopreviewfrom
Conversation
Contributor
WalkthroughThe update changes the condition for rendering sidebar items based on project views in the workspace sidebar. Specifically, it renames the "Inbox" item to "Intake" and adjusts the associated condition checks to reflect this change. This modification ensures that the sidebar accurately displays the updated project view names. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
SatishGandham
approved these changes
Jul 18, 2024
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
web/core/components/workspace/sidebar/projects-list-item.tsx (1)
The name change from "Inbox" to "Intake" is not consistent across the codebase.
The term "Inbox" is still widely used in the following files:
web/core/store/inbox/inbox-issue.store.tsweb/core/store/root.store.tsweb/core/store/inbox/project-inbox.store.tsweb/core/services/inbox/inbox-issue.service.tsweb/helpers/inbox.helper.tsweb/core/constants/dashboard.tsweb/core/components/workspace-notifications/sidebar/filters/menu/root.tsxweb/core/components/ui/loader/layouts/project-inbox/inbox-layout-loader.tsxweb/core/components/ui/loader/layouts/project-inbox/inbox-sidebar-loader.tsxweb/core/components/workspace-notifications/sidebar/header/root.tsxweb/core/components/issues/issue-detail/label/root.tsxweb/core/components/issues/issue-detail/issue-activity/activity/activity-list.tsxweb/core/components/issues/issue-detail/issue-activity/activity/actions/inbox.tsxweb/core/components/core/activity.tsxweb/core/components/inbox/root.tsxweb/core/components/inbox/inbox-issue-status.tsxweb/core/components/inbox/sidebar/inbox-list.tsxweb/core/components/inbox/sidebar/inbox-list-item.tsxweb/core/components/inbox/sidebar/root.tsxweb/core/components/inbox/inbox-filter/sorting/order-by.tsxweb/core/components/inbox/modals/snooze-issue-modal.tsxweb/core/components/inbox/modals/select-duplicate.tsxweb/core/components/inbox/inbox-filter/root.tsxweb/core/components/inbox/inbox-filter/filters/date.tsxweb/core/components/inbox/inbox-filter/filters/status.tsxweb/core/components/inbox/inbox-filter/filters/labels.tsxweb/core/components/inbox/inbox-filter/filters/filter-selection.tsxweb/core/components/inbox/inbox-filter/filters/members.tsxweb/core/components/inbox/inbox-filter/applied-filters/label.tsxweb/core/components/inbox/modals/create-edit-modal/edit-root.tsxweb/core/components/inbox/inbox-filter/filters/state.tsxweb/core/components/inbox/inbox-filter/applied-filters/status.tsxweb/core/components/inbox/inbox-filter/filters/priority.tsxweb/core/components/inbox/inbox-filter/applied-filters/priority.tsxweb/core/components/inbox/modals/create-edit-modal/create-root.tsxweb/core/components/inbox/content/issue-root.tsxweb/core/components/inbox/content/issue-properties.tsxweb/core/components/inbox/content/inbox-issue-mobile-header.tsxweb/core/components/inbox/content/inbox-issue-header.tsxweb/core/components/inbox/content/root.tsxweb/core/components/inbox/modals/create-edit-modal/issue-title.tsxweb/core/components/inbox/inbox-filter/applied-filters/member.tsxweb/core/constants/inbox.tsxweb/core/hooks/store/use-issue-detail.tsweb/core/hooks/store/use-project-inbox.tsweb/core/hooks/store/use-inbox-issues.tsweb/core/layouts/auth-layout/project-wrapper.tsxweb/app/[workspaceSlug]/(projects)/notifications/layout.tsxweb/app/[workspaceSlug]/(projects)/notifications/page.tsxpackages/types/src/inbox.d.tspackages/ui/src/emoji/icons.tsweb/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/inbox/header.tsxweb/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/inbox/page.tsxweb/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/inbox/layout.tsxapiserver/plane/api/urls/inbox.pyapiserver/plane/api/views/inbox.pyapiserver/plane/api/serializers/__init__.pyapiserver/plane/api/views/__init__.pyapiserver/plane/api/views/project.pyapiserver/plane/app/views/project/base.pyapiserver/plane/app/views/inbox/base.pyapiserver/plane/app/serializers/__init__.pyapiserver/plane/app/serializers/inbox.pyapiserver/plane/space/serializer/inbox.pyapiserver/plane/space/views/inbox.pyapiserver/plane/space/urls/inbox.pyapiserver/plane/db/migrations/0033_auto_20230618_2125.pyapiserver/plane/db/models/project.pyapiserver/plane/db/models/inbox.pyapiserver/plane/db/models/deploy_board.pyapiserver/plane/db/models/__init__.pyapiserver/plane/bgtasks/dummy_data_task.pyapiserver/plane/bgtasks/webhook_task.pyPlease ensure that the name "Intake" is used consistently throughout the codebase.
Analysis chain
Line range hint
55-55:
Verify the consistency of the name change.Ensure that the name "Intake" is used consistently throughout the codebase instead of "Inbox".
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that "Intake" is used consistently instead of "Inbox". # Test: Search for occurrences of "Inbox". Expect: No occurrences. rg --type js,jsx,ts,tsx 'Inbox'Length of output: 69
Script:
#!/bin/bash # Description: Verify that "Intake" is used consistently instead of "Inbox". # Test: Search for occurrences of "Inbox". Expect: No occurrences. rg --type-add 'web:*.{js,jsx,ts,tsx}' 'Inbox' # Test: Search for occurrences of "Intake". Expect: Occurrences in relevant places. rg --type-add 'web:*.{js,jsx,ts,tsx}' 'Intake'Length of output: 72713
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- web/core/components/workspace/sidebar/projects-list-item.tsx (1 hunks)
Additional comments not posted (1)
web/core/components/workspace/sidebar/projects-list-item.tsx (1)
473-473: Verify the correctness of the condition check.Ensure that
project.inbox_viewis correctly set and used throughout the codebase.Verification successful
Verified the correctness of the condition check.
The
project.inbox_viewis correctly set and used throughout the codebase.
projects.d.ts:inbox_viewis defined as a boolean.header.tsx,page.tsx,projects-list-item.tsx,features.tsx:inbox_viewis used appropriately.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that `project.inbox_view` is correctly set and used. # Test: Search for occurrences of `inbox_view`. Expect: Correct usage. rg --type js,jsx,ts,tsx 'inbox_view'Length of output: 74
Script:
#!/bin/bash # Description: Verify that `project.inbox_view` is correctly set and used. # Test: Search for occurrences of `inbox_view`. Expect: Correct usage. rg -t js -t jsx -t ts -t tsx 'inbox_view'Length of output: 69
Script:
#!/bin/bash # Description: Verify that `project.inbox_view` is correctly set and used. # Test: Search for occurrences of `inbox_view`. Expect: Correct usage. rg -t js -t ts -t tsx 'inbox_view'Length of output: 62
Script:
#!/bin/bash # Description: Verify that `project.inbox_view` is correctly set and used. # Test: Search for occurrences of `inbox_view`. Expect: Correct usage. rg -t js -t ts 'inbox_view'Length of output: 739
sriramveeraghanta
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
This PR includes following changes:
Issue link: [WEB-1920]
Summary by CodeRabbit