[WEB-1990] fix: issue activity render enum keys update#5162
[WEB-1990] fix: issue activity render enum keys update#5162sriramveeraghanta merged 1 commit intopreviewfrom
Conversation
WalkthroughThe changes in the codebase primarily involve updating the enum values in Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- web/ce/constants/issues.ts (1 hunks)
Additional comments not posted (2)
web/ce/constants/issues.ts (2)
7-7: LGTM!The change ensures that
TActivityFiltersis directly tied to the enum, enforcing consistency.
4-5: LGTM! But verify the enum references in the codebase.The changes to the enum values standardize the constants and potentially avoid errors due to case sensitivity.
However, ensure that all references to
EActivityFilterType.ACTIVITYandEActivityFilterType.COMMENTin the codebase are updated accordingly.Verification successful
Verification Successful: Enum References Updated
The references to
EActivityFilterType.ACTIVITYandEActivityFilterType.COMMENThave been correctly updated within the same file.
web/ce/constants/issues.ts: Verified references to updated enum values.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to `EActivityFilterType.ACTIVITY` and `EActivityFilterType.COMMENT` in the codebase. # Test: Search for the enum references. Expect: Only occurrences of the new uppercase values. rg --type typescript -A 5 $'EActivityFilterType.ACTIVITY' rg --type typescript -A 5 $'EActivityFilterType.COMMENT'Length of output: 182
Script:
#!/bin/bash # Description: Verify all references to `EActivityFilterType.ACTIVITY` and `EActivityFilterType.COMMENT` in the codebase. # Search for the enum references in TypeScript files. Expect: Only occurrences of the new uppercase values. rg --glob '*.ts' -A 5 'EActivityFilterType.ACTIVITY' rg --glob '*.ts' -A 5 'EActivityFilterType.COMMENT'Length of output: 670
Summary
Changes
Issue link: [WEB-1990]