Skip to content

Comments

[WEB-1990] fix: issue activity render enum keys update#5162

Merged
sriramveeraghanta merged 1 commit intopreviewfrom
fix/issue-activity-enum-worklog
Jul 18, 2024
Merged

[WEB-1990] fix: issue activity render enum keys update#5162
sriramveeraghanta merged 1 commit intopreviewfrom
fix/issue-activity-enum-worklog

Conversation

@gurusainath
Copy link
Member

@gurusainath gurusainath commented Jul 18, 2024

Summary

  • This PR resolves the issue activity components rendered on the issue peek overview and issue detail page

Changes

  1. Issue activity constants

Issue link: [WEB-1990]

@gurusainath gurusainath added this to the v0.23-dev milestone Jul 18, 2024
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 18, 2024

Walkthrough

The changes in the codebase primarily involve updating the enum values in EActivityFilterType from lowercase to uppercase (ACTIVITY and COMMENT) and modifying the TActivityFilters type to reference the updated enum. This adjustment standardizes the enumeration constants, ensuring consistency and potentially avoiding errors due to case sensitivity.

Changes

Files Change Summary
web/ce/constants/issues.ts Updated enum EActivityFilterType values to uppercase (ACTIVITY, COMMENT). Modified TActivityFilters to use the updated enum.

Poem

In code we trust, enums we reform,
To uppercase letters, we now conform.
With ACTIVITY and COMMENT standing tall,
Our constants strong, no errors befall.
🐰✨ CodeRabbit hops with cheer,
For cleaner paths, the future's clear!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4ce255a and 1b9cd8c.

Files selected for processing (1)
  • web/ce/constants/issues.ts (1 hunks)
Additional comments not posted (2)
web/ce/constants/issues.ts (2)

7-7: LGTM!

The change ensures that TActivityFilters is directly tied to the enum, enforcing consistency.


4-5: LGTM! But verify the enum references in the codebase.

The changes to the enum values standardize the constants and potentially avoid errors due to case sensitivity.

However, ensure that all references to EActivityFilterType.ACTIVITY and EActivityFilterType.COMMENT in the codebase are updated accordingly.

Verification successful

Verification Successful: Enum References Updated

The references to EActivityFilterType.ACTIVITY and EActivityFilterType.COMMENT have been correctly updated within the same file.

  • web/ce/constants/issues.ts: Verified references to updated enum values.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all references to `EActivityFilterType.ACTIVITY` and `EActivityFilterType.COMMENT` in the codebase.

# Test: Search for the enum references. Expect: Only occurrences of the new uppercase values.
rg --type typescript -A 5 $'EActivityFilterType.ACTIVITY'
rg --type typescript -A 5 $'EActivityFilterType.COMMENT'

Length of output: 182


Script:

#!/bin/bash
# Description: Verify all references to `EActivityFilterType.ACTIVITY` and `EActivityFilterType.COMMENT` in the codebase.

# Search for the enum references in TypeScript files. Expect: Only occurrences of the new uppercase values.
rg --glob '*.ts' -A 5 'EActivityFilterType.ACTIVITY'
rg --glob '*.ts' -A 5 'EActivityFilterType.COMMENT'

Length of output: 670

@gurusainath gurusainath changed the title [WEB-1883] fix: issue activity render enum keys update [WEB-1990] fix: issue activity render enum keys update Jul 18, 2024
@sriramveeraghanta sriramveeraghanta merged commit 8107045 into preview Jul 18, 2024
@sriramveeraghanta sriramveeraghanta deleted the fix/issue-activity-enum-worklog branch July 18, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants