[WEB-2021] fix: mutating the inbox count on the sidebar and inbox tab when we click mark all as read#5191
Conversation
…ick mark all as read
WalkthroughThe changes enhance the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- web/core/store/notifications/workspace-notifications.store.ts (1 hunks)
Additional comments not posted (1)
web/core/store/notifications/workspace-notifications.store.ts (1)
376-382: LGTM! But verify the correct usage of theupdatefunction andcurrentNotificationTab.The code changes are approved. The
updatefunction is used to set the unread notifications count to zero based on the current notification tab.However, ensure that the
updatefunction is used correctly and that thecurrentNotificationTabis set appropriately elsewhere in the code.
Problem Statement:
In the inbox, when we click the option
mark all as readthe notification count is not mutating in the workspace app sidebar badge and inbox tab badgeSolution:
When we click
mark all as readin the inbox we are mutating the storeunread notification countobserverChanges:
Plane Issue:
[WEB-2021]
Summary by CodeRabbit