[WEB-1833] fix: editor bold text color#5197
Conversation
WalkthroughThe recent update to the Tailwind CSS configuration enhances the handling of bold text within prose elements. By changing the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/tailwind-config-custom/tailwind.config.js (1 hunks)
Additional comments not posted (1)
packages/tailwind-config-custom/tailwind.config.js (1)
273-273: LGTM! Update to--tw-prose-boldproperty improves readability.The change to set
--tw-prose-boldto "inherit" ensures that bold text inherits its color from the parent element, which enhances readability, especially in tables with colored backgrounds.
Problem:
When making a table content bold when background color is applied to the row/column, the text color changes to invert mode making it impossible to read.
Solution:
Updated the bold text color from primary text to inherit the parent's text color.
Media:
Screen.Recording.2024-07-22.at.19.33.50.mov
Screen.Recording.2024-07-22.at.19.28.52.mov
Plane issue: WEB-1833
Summary by CodeRabbit
New Features
Bug Fixes