Skip to content

[WEB-1955] fix: data types and css fixes added #5216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SatishGandham merged 2 commits into from
Jul 24, 2024
Merged

[WEB-1955] fix: data types and css fixes added #5216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caaa5dd
fix: data types and css fixes for bulk ops
gakshita Jul 24, 2024
b975423
fix: TBulkIssueProperties keys
gakshita Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions packages/types/src/issues/issue.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { TIssuePriorities } from "../issues";
import { TIssueAttachment } from "./issue_attachment";
import { TIssueLink } from "./issue_link";
import { TIssueReaction } from "./issue_reaction";
import {TIssuePriorities} from "../issues";
import {TIssueAttachment} from "./issue_attachment";
import {TIssueLink} from "./issue_link";
import {TIssueReaction} from "./issue_reaction";

// new issue structure types

Expand Down Expand Up @@ -42,13 +42,10 @@ export type TBaseIssue = {
export type TIssue = TBaseIssue & {
description_html?: string;
is_subscribed?: boolean;

parent?: partial<TIssue>;

parent?: Partial<TIssue>;
issue_reactions?: TIssueReaction[];
issue_attachment?: TIssueAttachment[];
issue_link?: TIssueLink[];

// tempId is used for optimistic updates. It is not a part of the API response.
tempId?: string;
};
Expand Down Expand Up @@ -94,6 +91,9 @@ export type TBulkIssueProperties = Pick<
| "assignee_ids"
| "start_date"
| "target_date"
| "module_ids"
| "cycle_id"
| "estimate_point"
>;

export type TBulkOperationsPayload = {
Expand Down
6 changes: 4 additions & 2 deletions web/core/components/dropdowns/module/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ type Props = TDropdownProps & {
| {
multiple: true;
onChange: (val: string[]) => void;
value: string[];
value: string[] | null;
}
);

Expand Down Expand Up @@ -139,7 +139,9 @@ const ButtonContent: React.FC<ButtonContentProps> = (props) => {
return (
<>
{!hideIcon && <DiceIcon className="h-3 w-3 flex-shrink-0" />}
{!hideText && <span className="flex-grow truncate text-left">{value ?? placeholder}</span>}
{!hideText && (
<span className="flex-grow truncate text-left">{value ? getModuleById(value)?.name : placeholder}</span>
)}
{dropdownArrow && (
<ChevronDown className={cn("h-2.5 w-2.5 flex-shrink-0", dropdownArrowClassName)} aria-hidden="true" />
)}
Expand Down
3 changes: 2 additions & 1 deletion web/core/components/ui/labels-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ export const IssueLabelsList: FC<IssueLabelsListProps> = (props) => {
>
<div className="h-full flex items-center gap-1 rounded border-[0.5px] border-custom-border-300 px-2 py-1 text-xs text-custom-text-200">
<span className="h-2 w-2 flex-shrink-0 rounded-full bg-custom-primary" />
{`${labels.length} Labels`}
<span>{labels.length}</span>
<span> Labels</span>
</div>
</Tooltip>
</>
Expand Down