[WEB-2029] fix: active cycle filter

[gakshita]

Summary
Project was taking the the first cycle as the active cycle

Fix
currentProjectActiveCycleId was missing the status === 'current' check

[WEB-2029]

Summary by CodeRabbit

• Bug Fixes

  • Improved the alignment and visual consistency in the Active Cycle Productivity component by removing unnecessary margin styles.

• New Features

  • Enhanced the logic for retrieving the active cycle to ensure only cycles marked as "current" are considered, improving the accuracy of cycle data displayed to users.

[coderabbitai]

Walkthrough

The recent changes enhance the ActiveCycleProductivity component and the CycleStore class by refining their respective functionalities. The visual layout of the ActiveCycleProductivity component has been improved by removing an unnecessary margin, while the CycleStore has been optimized to ensure that only cycles marked as "current" for the appropriate project are recognized as active. These adjustments contribute to a cleaner user interface and improved logic in cycle management.

Changes

File	Change Summary
web/core/components/cycles/.../productivity.tsx	Removed unnecessary margin-top style from ActiveCycleProductivity, enhancing layout consistency.
web/core/store/cycle.store.ts	Updated active cycle retrieval logic to include a check for "current" status alongside project_id.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ActiveCycleProductivity
    participant CycleStore

    User->>ActiveCycleProductivity: Request active cycle data
    ActiveCycleProductivity->>CycleStore: Fetch active cycle
    CycleStore->>CycleStore: Filter cycles by project_id and status
    CycleStore-->>ActiveCycleProductivity: Return current active cycle
    ActiveCycleProductivity-->>User: Display cycle data

Loading

Poem

🐰 In the meadow, bright and wide,
Our cycles now align with pride.
A margin gone, the view is clear,
Current cycles, bring us cheer!
Hopping forth with joy anew,
Each change a hop, each day a view! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ca088a4 and f24b27e.

Files selected for processing (2)

• web/core/components/cycles/active-cycle/productivity.tsx (1 hunks)
• web/core/store/cycle.store.ts (1 hunks)

Files skipped from review due to trivial changes (1)

• web/core/components/cycles/active-cycle/productivity.tsx

Additional comments not posted (1)

web/core/store/cycle.store.ts (1)

216-218: LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to currentProjectActiveCycleId correctly handle the new logic.