[WEB-1973] fix: Gantt layout in project views#5218
Conversation
WalkthroughThe recent changes improve the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- web/core/components/issues/issue-layouts/roots/project-view-layout-root.tsx (1 hunks)
Additional comments not posted (1)
web/core/components/issues/issue-layouts/roots/project-view-layout-root.tsx (1)
32-32: LGTM! Verify the correct usage of theviewIdprop.The addition of the
viewIdprop to theBaseGanttRootcomponent looks good.However, ensure that the
viewIdis correctly utilized within theBaseGanttRootcomponent.Verification successful
Verified: The
viewIdprop is correctly utilized within theBaseGanttRootcomponent.
- The
viewIdprop is passed to theBaseGanttRootcomponent inproject-view-layout-root.tsx.- The
viewIdprop is defined and utilized within theBaseGanttRootcomponent inbase-gantt-root.tsx.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct usage of the `viewId` prop within `BaseGanttRoot`. # Test: Search for the `viewId` prop usage within the `BaseGanttRoot` component. Expect: Proper utilization of the `viewId` prop. rg --type tsx -A 10 'BaseGanttRoot'Length of output: 63
Script:
#!/bin/bash # Description: Verify the correct usage of the `viewId` prop within `BaseGanttRoot`. # Test: Search for the `viewId` prop usage within the `BaseGanttRoot` component. Expect: Proper utilization of the `viewId` prop. rg 'BaseGanttRoot' -A 10Length of output: 11158
This PR fixes the gantt in project views by passing down the missing viewId to the base gantt layout
Summary by CodeRabbit
viewIdprop, improving its interaction and rendering capabilities based on context.