[WEB-2039] chore: issue parent type

[aaryan610]

This PR fixes the typo in the type of parent filed in the TIssue.

Summary by CodeRabbit

• Bug Fixes

  • Improved error handling in the drag and drop functionality to ensure that type mismatches do not occur, enhancing the overall stability of the feature.

• Improvements

  • Enhanced the handling of issue fields to support nested structures better, simplifying future modifications and improving maintainability.

• Documentation

  • Minor formatting adjustments for adherence to coding conventions.

[coderabbitai]

Walkthrough

Recent changes enhance type safety, improve error handling, and refine property management within the codebase. Adjustments to the TIssue type ensure better structure for issue hierarchy, while enhancements in the drag-and-drop functionality boost robustness against type mismatches. Additionally, the use of Lodash in the getChangedIssuefields function simplifies nested property handling. These modifications collectively improve maintainability and user experience across the application.

Changes

File	Change Summary
packages/types/src/issues/issue.d.ts	Changed parent property in TIssue from Partial<TIssue> to Partial<TBaseIssue>.
web/core/hooks/use-group-dragndrop.ts	Enhanced error handling in useGroupIssuesDragNDrop: uses optional chaining and nullish coalescing for addCycleToIssue.
web/helpers/issue.helper.ts	Replaced direct property assignment with Lodash's set in getChangedIssuefields for improved nested property handling. Minor formatting adjustment added.

Sequence Diagram(s)

sequenceDiagram
    participant A as User
    participant B as useGroupIssuesDragNDrop
    participant C as addCycleToIssue

    A->>B: Initiate drag and drop
    B->>C: Call addCycleToIssue with cycle data
    C-->>B: Cycle added successfully
    B-->>A: Update UI with new state

Loading

🐇 "In the code where issues bloom,
A parent type finds newfound room.
With chains of safety wrapped around,
And nested fields in Lodash found.
Let's hop along, rejoice and cheer,
For changes made, the future's clear!" 🐰

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4d978c1 and b69a371.

Files selected for processing (3)

• packages/types/src/issues/issue.d.ts (1 hunks)
• web/core/hooks/use-group-dragndrop.ts (1 hunks)
• web/helpers/issue.helper.ts (3 hunks)

Additional comments not posted (3)

packages/types/src/issues/issue.d.ts (1)

45-45: LGTM! But verify the usage of the parent property in the codebase.

The change from Partial<TIssue> to Partial<TBaseIssue> simplifies the structure of the parent property and improves maintainability.

However, ensure that all references to the parent property in the codebase are updated accordingly.

web/core/hooks/use-group-dragndrop.ts (1)

68-68: LGTM!

The use of optional chaining and a nullish coalescing operator improves the robustness of the function by ensuring that the third parameter passed to addCycleToIssue is always a string.

web/helpers/issue.helper.ts (1)

188-188: LGTM!

The use of the set function from Lodash enhances the flexibility of the getChangedIssuefields function by allowing it to handle nested properties.