[WEB-2031] fix: display update view button even when any filters are not applied for views

[rahulramesha]

This PR fixes the issue when update view button is not dislayed when no filters are applied even when display filters or properties are changed

Screen.Recording.2024-07-24.at.6.19.37.PM.mov

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling for appliedFilters in the Global Views and Project View components, preventing potential runtime errors due to undefined values.

[coderabbitai]

Walkthrough

The changes enhance the error handling of the GlobalViewsAppliedFiltersRoot and ProjectViewAppliedFiltersRoot components by safeguarding the appliedFilters variable against being undefined. Utilizing the nullish coalescing operator (??), the code ensures that both components operate with a default empty object when necessary. This improvement adds robustness while maintaining the original functionality, preventing potential runtime errors linked to undefined values.

Changes

Files	Change Summary
web/core/components/issues/issue-layouts/filters/applied-filters/roots/global-view-root.tsx	Added a safeguard for appliedFilters using nullish coalescing to prevent errors when it is undefined.
web/core/components/issues/issue-layouts/filters/applied-filters/roots/project-view-root.tsx	Implemented similar safeguards for appliedFilters and viewFilters in the ProjectViewAppliedFiltersRoot component, enhancing error handling.

Poem

In code we hop, with filters so bright,
Safeguards in place, to banish the fright.
Undefined no more, we dance through the night,
Error-free joy, everything feels right!
A little change, but oh, what a cheer,
For robust components, we hold dear! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4d978c1 and 758fecf.

Files selected for processing (2)

• web/core/components/issues/issue-layouts/filters/applied-filters/roots/global-view-root.tsx (1 hunks)
• web/core/components/issues/issue-layouts/filters/applied-filters/roots/project-view-root.tsx (1 hunks)

Additional comments not posted (2)

web/core/components/issues/issue-layouts/filters/applied-filters/roots/project-view-root.tsx (1)

94-95: Robustness Improvement: Safeguard against undefined appliedFilters.

The use of the nullish coalescing operator ensures that getAreFiltersEqual always receives a valid object, preventing potential runtime errors.

web/core/components/issues/issue-layouts/filters/applied-filters/roots/global-view-root.tsx (1)

120-121: Robustness Improvement: Safeguard against undefined appliedFilters.

The use of the nullish coalescing operator ensures that getAreFiltersEqual always receives a valid object, preventing potential runtime errors.