[WEB-2042] fix: project publish issue loader and error handling

[rahulramesha]

This PR addresses the issue with loader and error states in project publish.

Changes include,

1. Displaying error state when publish settings call has errored out
2. Remove unnecessary loading state in root state, so that it doesn't hinder the layout level loading handler

Summary by CodeRabbit

• New Features

  • Introduced a user-friendly error component that informs users when there is an issue with fetching publish settings.

• Bug Fixes

  • Improved error handling in the IssuesLayout component, providing clear feedback to users during data fetching failures.

• Refactor

  • Streamlined the internal logic of the IssuesLayoutsRoot component to enhance readability and maintainability while preserving core functionalities.

[coderabbitai]

Walkthrough

The recent updates enhance error handling within the issue layout components, improving user feedback during data fetching processes. Specifically, a new error component, SomethingWentWrongError, has been introduced to provide clear error messages. The adjustments streamline the rendering logic, ensuring users receive timely notifications regarding issues while maintaining a clean and efficient component structure.

Changes

Files	Change Summary
space/app/issues/[anchor]/layout.tsx	Improved error handling; added SomethingWentWrongError for better user feedback during data fetching.
space/core/components/issues/issue-layouts/error.tsx	Introduced SomethingWentWrongError component for displaying user-friendly error messages.
space/core/components/issues/issue-layouts/root.tsx	Refactored IssuesLayoutsRoot to simplify error handling and remove unnecessary state variables.

Poem

In a world of bits and bytes,
A rabbit hops with joyful lights.
Errors now are met with cheer,
For clear messages draw near.
With each fetch, there's no more fright,
Just friendly words, all feels just right! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1f9c7a4 and b1ae8f7.

Files selected for processing (3)

• space/app/issues/[anchor]/layout.tsx (3 hunks)
• space/core/components/issues/issue-layouts/error.tsx (1 hunks)
• space/core/components/issues/issue-layouts/root.tsx (4 hunks)

Additional comments not posted (9)

space/core/components/issues/issue-layouts/error.tsx (2)

1-3: Import statements look good.

The imports are correct and necessary for the component.

---

5-17: Component implementation looks good.

The SomethingWentWrongError component is correctly implemented and adheres to best practices.

space/core/components/issues/issue-layouts/root.tsx (4)

15-15: Import statement looks good.

The import of the SomethingWentWrongError component is correct and necessary.

---

26-26: Implementation of useSWR hook looks good.

The useSWR hook is correctly implemented and handles errors appropriately.

---

50-51: Error handling logic looks good.

The error handling logic correctly uses the SomethingWentWrongError component to display errors.

---

55-70: Rendering logic looks good.

The rendering logic for IssuePeekOverview, IssueAppliedFilters, IssuesListLayoutRoot, and IssueKanbanLayoutRoot is correctly implemented and adheres to best practices.

space/app/issues/[anchor]/layout.tsx (3)

9-9: Import statement looks good.

The import of the SomethingWentWrongError component is correct and necessary.

---

31-31: Implementation of useSWR hook looks good.

The useSWR hook is correctly implemented and handles errors appropriately.

---

49-51: Error handling logic looks good.

The error handling logic correctly uses the SomethingWentWrongError component to display errors.