[WEB-2013] fix: issue link modal preloading previous data

[anmolsinghbhatia]

Problem:

• The issue link modal was preloading data from the previous link.

Solution:

• Made necessary changes to reset the data to default on submit and on close, ensuring the modal does not preload previous link data.

Reference:

[WEB-2013]

Media:

Before	After

Summary by CodeRabbit

• New Features

  • Enhanced responsiveness of the Issue Link Create/Update modal to observable state changes.

• Improvements

  • The modal now resets to its default state upon closure, improving user experience by preventing stale data.
  • Form resets are now conditionally triggered, optimizing performance when the modal is open.

[coderabbitai]

Walkthrough

The recent changes to the IssueLinkCreateUpdateModal component enhance its responsiveness and state management. By integrating the observer function from mobx-react, the component now automatically re-renders with observable data changes. Additionally, improvements in the onClose function and the useEffect hook ensure that the form resets appropriately, optimizing performance and user experience.

Changes

Files	Change Summary
web/core/components/issues/issue-detail/links/create-update-link-modal.tsx	The IssueLinkCreateUpdateModal component is now wrapped with observer for better observability. The form resets to default values on modal close, and the useEffect hook resets the form conditionally based on modal state.

Poem

In the modal, changes bloom,
Forms reset, making room.
With every close, fresh and bright,
Observing states, a joyful sight.
Hops of code, so swift and neat,
Celebrate this rhythm, oh so sweet! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between dfcba4d and d23499b.

Files selected for processing (1)

• web/core/components/issues/issue-detail/links/create-update-link-modal.tsx (5 hunks)

Additional comments not posted (4)

web/core/components/issues/issue-detail/links/create-update-link-modal.tsx (4)

4-4: LGTM!

The addition of the observer function from mobx-react is appropriate for making the component reactive to observable state changes.

---

31-31: LGTM!

Wrapping the component with the observer function ensures it re-renders when observable data changes, which is necessary for proper state management with MobX.

---

49-49: LGTM!

The inclusion of reset(defaultValues) in the onClose function ensures the form resets to its default state whenever the modal is closed, preventing stale data from persisting.

---

60-61: LGTM!

The update to the useEffect hook ensures the form is reset with the combined values of defaultValues and preloadedData only when the modal is actively being displayed, optimizing performance and preventing unnecessary resets.