[WEB-2102] feat: Block level reactions for Kanban layout in Space App#5272
[WEB-2102] feat: Block level reactions for Kanban layout in Space App#5272SatishGandham merged 1 commit intopreviewfrom
Conversation
WalkthroughThe recent changes introduce a new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant KanbanIssueBlock
participant BlockReactions
participant IssueVotes
participant IssueEmojiReactions
User->>KanbanIssueBlock: Interacts with Issue
KanbanIssueBlock->>BlockReactions: Render Reactions Component
BlockReactions->>IssueVotes: Check Voting Permissions
BlockReactions->>IssueEmojiReactions: Check Reaction Permissions
IssueVotes->>User: Show Voting Options
IssueEmojiReactions->>User: Show Emoji Reactions
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (2)
space/core/components/issues/issue-layouts/kanban/block-reactions.tsx (2)
3-4: Consider removing theplanecomment.The comment
//planeseems unnecessary and can be removed for cleaner code.- //plane
10-12: Consider adding PropTypes for type validation.Adding PropTypes can help with runtime type checking and improve code maintainability.
+ import PropTypes from 'prop-types'; BlockReactions.propTypes = { issueId: PropTypes.string.isRequired, };
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (7)
- space/core/components/issues/issue-layouts/kanban/block-reactions.tsx (1 hunks)
- space/core/components/issues/issue-layouts/kanban/block.tsx (2 hunks)
- space/core/components/issues/peek-overview/index.ts (1 hunks)
- space/core/components/issues/peek-overview/issue-reaction.tsx (1 hunks)
- space/core/components/issues/reactions/index.ts (1 hunks)
- space/core/components/issues/reactions/issue-emoji-reactions.tsx (4 hunks)
- space/core/components/issues/reactions/issue-vote-reactions.tsx (5 hunks)
Files skipped from review due to trivial changes (2)
- space/core/components/issues/peek-overview/issue-reaction.tsx
- space/core/components/issues/reactions/index.ts
Additional comments not posted (15)
space/core/components/issues/peek-overview/index.ts (1)
Line range hint
1-9:
Verify the impact of removed exports.The removal of
issue-vote-reactionsandissue-emoji-reactionsexports aligns with the introduction of block-level reactions. Ensure that other parts of the codebase are updated accordingly to prevent any broken imports.space/core/components/issues/issue-layouts/kanban/block-reactions.tsx (4)
1-2: LGTM!The imports for MobX and Next.js are appropriate for the component's functionality.
6-8: LGTM!The imports for custom components and hooks are appropriate for the component's functionality.
13-19: LGTM!The component correctly uses MobX's
observerand the custom hooks to manage state and permissions.
21-45: LGTM!The component correctly renders the reaction components based on user permissions and uses appropriate styling.
space/core/components/issues/issue-layouts/kanban/block.tsx (2)
21-21: LGTM!The import for the
BlockReactionscomponent is appropriate.
87-102: LGTM!The integration of the
BlockReactionscomponent within theKanbanIssueBlockis correctly implemented and follows best practices.space/core/components/issues/reactions/issue-emoji-reactions.tsx (4)
16-17: New optional properties added toIssueEmojiReactionsProps.The properties
issueIdFromPropsandsizeenhance the flexibility and customization of the component.
21-21: Props destructuring updated.The destructuring correctly includes the new properties
issueIdFromPropsandsizewith a default value forsize.
36-36: Improved flexibility and customization.The logic for determining
issueIdand the rendering of emoji buttons using thesizeprop enhances the component's flexibility and customization.Also applies to: 60-60, 70-70
72-100: Dynamic styling based onsizeprop.The dynamic styling based on the
sizeprop ensures that the component can adapt its appearance to different UI requirements.space/core/components/issues/reactions/issue-vote-reactions.tsx (4)
16-17: New optional properties added toTIssueVotes.The properties
issueIdFromPropsandsizeenhance the flexibility and customization of the component.
21-21: Props destructuring updated.The destructuring correctly includes the new properties
issueIdFromPropsandsizewith a default value forsize.
40-40: Improved flexibility with external issue ID.The logic for determining
issueIdnow allows for an external issue ID, enhancing the component's flexibility.
71-71: Dynamic styling based onsizeprop.The dynamic styling based on the
sizeprop ensures that the component can adapt its appearance to different UI requirements.Also applies to: 102-103, 143-144
2 participants
This PR adds the ability to react to an issue from the issue block in kanban layout, without having to open the issue to do it.
Screen.Recording.2024-07-30.at.6.20.19.PM.mov
Summary by CodeRabbit
New Features
Bug Fixes
Refactor