[WEB-2140] fix: member setting role edit validation

[anmolsinghbhatia]

Changes:

This PR addresses an issue with role edit validation in member settings. Updated the logic to ensure it works as intended

Reference:

[WEB-2140]

Summary by CodeRabbit

• New Features
  • Updated logic for displaying user roles in the account settings, allowing for more users to view their roles without needing admin privileges.
  • Enhanced flexibility in role visibility, improving user experience in managing roles within the application.

[coderabbitai]

Walkthrough

The changes enhance the AccountTypeColumn component by broadening the conditions under which user roles are displayed. The logic for determining editability has shifted from a restrictive model (requiring admin privileges) to a more inclusive approach, allowing roles to be visible to both the current user and non-admins. This modification aims to improve user experience by facilitating greater visibility of roles without the necessity of admin access.

Changes

Files	Change Summary
web/core/components/project/settings/...	Updated logic in AccountTypeColumn to allow role display for current users or non-admins, replacing restrictive checks.
web/core/components/workspace/settings/...	Similar logic change in AccountTypeColumn, enhancing role display conditions for user experience.

Poem

🐇 In fields of code where rabbits roam,
Roles once hidden now find a home.
With fewer rules, the view is bright,
Every user shines in their rightful light.
So hop along, let freedom ring,
For every role, a joyful spring! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8415df4 and 13c6abb.

Files selected for processing (2)

• web/core/components/project/settings/member-columns.tsx (1 hunks)
• web/core/components/workspace/settings/member-columns.tsx (1 hunks)

Additional comments not posted (4)

web/core/components/project/settings/member-columns.tsx (2)

100-100: Review the logic for role editability.

The new condition isRoleNonEditable allows roles to be displayed if the user is either the current user or not an admin. This broadens the conditions under which roles are visible.

Ensure that this change aligns with the intended functionality and does not introduce any security or access control issues.

---

Line range hint 104-123:
Ensure proper error handling and user feedback.

The code handles errors when updating member roles and provides user feedback through toast notifications. This is good practice for enhancing user experience.

Verify that the error messages are user-friendly and provide enough context for troubleshooting.

web/core/components/workspace/settings/member-columns.tsx (2)

99-99: Review the logic for role editability.

The new condition isRoleNonEditable allows roles to be displayed if the user is either the current user or not an admin. This broadens the conditions under which roles are visible.

Ensure that this change aligns with the intended functionality and does not introduce any security or access control issues.

---

Line range hint 103-122:
Ensure proper error handling and user feedback.

The code handles errors when updating member roles and provides user feedback through toast notifications. This is good practice for enhancing user experience.

Verify that the error messages are user-friendly and provide enough context for troubleshooting.