[WEB-1907] fix: favorite improvements

[gakshita]

[WEB-1907]

Summary by CodeRabbit

• New Features

  • Sidebar project list now dynamically opens based on the project URL.
  • Enhanced sidebar functionality to automatically expand when navigating to project-related pages.

• Improvements

  • Improved interactivity with conditional rendering and smoother animations for the project list.
  • Enhanced data management in the project page, ensuring favorites are updated when pages are removed.

• Bug Fixes

  • Resolved issues related to sidebar visibility and state management for favorite items.

[coderabbitai]

Walkthrough

The recent updates enhance the sidebar's functionality and state management in the application, particularly concerning project visibility. New state variables and hooks allow the interface to dynamically respond to URL changes and user interactions, improving the overall user experience. The integration of routing mechanisms ensures that relevant project lists are displayed promptly, while additional initializations enhance state control during data fetching.

Changes

Files	Change Summary
web/core/components/workspace/sidebar/...	Introduced state variables to manage project list visibility, allowing dynamic opening based on URL and user actions. Enhanced rendering logic and animations.
web/core/store/favorite.store.ts	Initialized properties (favoriteIds, favoriteMap, and entityMap) in fetchFavorite method to reset state before fetching favorites.
web/core/store/pages/project-page.store.ts	Added rootStore property for better state interaction and updated removePage method to maintain data consistency by removing associated favorites upon page removal.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Sidebar
    participant URL

    User->>Sidebar: Access project via URL
    Sidebar->>URL: Check current project ID
    URL-->>Sidebar: Return project ID
    Sidebar->>Sidebar: Set isProjectListOpen to true
    Sidebar->>User: Display project list

Loading

🐇 In the sidebar, the projects now bloom,
Click and toggle, dispelling all gloom.
With each new page, the lists expand wide,
A joyful journey, come take a ride!
State management dances, so smooth and bright,
In our little code world, everything feels right! 🌼✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 07574b4 and 39fbec3.

Files selected for processing (4)

• web/core/components/workspace/sidebar/projects-list-item.tsx (3 hunks)
• web/core/components/workspace/sidebar/projects-list.tsx (3 hunks)
• web/core/store/favorite.store.ts (1 hunks)
• web/core/store/pages/project-page.store.ts (3 hunks)

Additional comments not posted (8)

web/core/store/pages/project-page.store.ts (2)

56-56: Addition of rootStore property looks good.

The rootStore property is correctly typed and initialized in the constructor.

---

262-265: Changes in removePage method look good.

The method correctly interacts with the rootStore to maintain data consistency by removing associated favorites.

web/core/components/workspace/sidebar/projects-list.tsx (2)

46-47: Addition of usePathname hook looks good.

The usePathname hook is correctly imported and used to access the current pathname.

---

132-137: Changes in useEffect hook look good.

The useEffect hook correctly updates the state based on the pathname, enhancing user experience by expanding the sidebar for project-related paths.

web/core/store/favorite.store.ts (1)

402-404: Initialization of properties in fetchFavorite method looks good.

The properties favoriteIds, favoriteMap, and entityMap are correctly initialized to ensure a clean state before fetching favorites.

web/core/components/workspace/sidebar/projects-list-item.tsx (3)

114-114: LGTM!

The addition of the isProjectListOpen state variable is well-implemented to manage the visibility of the project list.

---

270-272: LGTM!

The useEffect hook correctly sets isProjectListOpen based on the URLProjectId, ensuring the project list is dynamically opened.

---

278-472: LGTM!

The use of the isProjectListOpen state variable in the Disclosure component's defaultOpen prop and the Transition component is well-implemented, enhancing the interactivity and responsiveness of the project list.