[WEB-2182] chore: user favorites item enhancements

[anmolsinghbhatia]

Changes:

This PR includes following changes:

• Fixed the icon type and alignment for user favorites.
• Improved the clickable area for favorite items, expanding it from just the title and icon to the entire item.

Reference:

[WEB-2182]

Summary by CodeRabbit

• New Features

  • Improved visual representation of favorite folder items with enhanced styling.
  • Enhanced icon display logic for favorite items, making it more responsive based on user interaction.
  • Dynamic logo type rendering based on the context of favorite items for better adaptability.

• Bug Fixes

  • Streamlined component structure for cleaner organization of the favorite item display, enhancing the user interface.

• Refactor

  • Optimized integration of the CustomMenu component for improved visibility and interactivity.

[coderabbitai]

Walkthrough

The recent updates enhance the user interface of the favorite items in the application. The FavoriteFolder component’s visual prominence is improved through a class name change, while the FavoriteItem component receives significant structural and functional refinements. These changes include improved icon rendering, dynamic logo display, and optimized user interactions, all contributing to a more responsive and visually coherent sidebar experience.

Changes

Files	Change Summary
web/core/components/workspace/sidebar/favorites/favorite-folder.tsx, web/core/components/workspace/sidebar/favorites/favorite-item.tsx	The favorite-folder.tsx modifies a class name for visual enhancement. The favorite-item.tsx includes various updates to icon rendering, conditional logo display, and JSX structure for improved responsiveness. The FavoriteItem is now wrapped in observer for better state management.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Sidebar
    participant FavoriteItem
    participant Logo

    User->>Sidebar: Hover over Favorite Item
    Sidebar->>FavoriteItem: Trigger Icon Display
    FavoriteItem->>Logo: Determine Display Based on Entity Type
    Logo-->>FavoriteItem: Return Appropriate Logo
    FavoriteItem-->>Sidebar: Render Updated State

Loading

Poem

In the sidebar, bright and neat,
A folder's glow, a favorite treat.
Icons dance with joyful grace,
Logos shift, each finds its place.
Hops of joy, for changes made,
In the UI's lovely parade! 🐰✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 598846a and 49325d2.

Files selected for processing (2)

• web/core/components/workspace/sidebar/favorites/favorite-folder.tsx (1 hunks)
• web/core/components/workspace/sidebar/favorites/favorite-item.tsx (4 hunks)

Files skipped from review due to trivial changes (1)

• web/core/components/workspace/sidebar/favorites/favorite-folder.tsx

Additional comments not posted (3)

web/core/components/workspace/sidebar/favorites/favorite-item.tsx (3)

65-74: Enhance icon visibility on hover.

The changes improve the visibility of icons when the user hovers over the group. The conditional rendering of the Logo component based on favorite.entity_data?.logo_props?.in_use is logical and enhances the user interface.

---

141-153: Streamline JSX for collapsed sidebar state.

The changes streamline the JSX for the collapsed sidebar state, making it more concise and improving readability. The use of the cn function for conditional class names is appropriate.

---

Line range hint 155-217:
Streamline JSX for expanded sidebar state.

The changes streamline the JSX for the expanded sidebar state, making it more concise and improving readability. The use of the cn function for conditional class names is appropriate. The integration of the CustomMenu component is logical and enhances user interaction.