[WEB-2186] fix: work log activity validation

[anmolsinghbhatia]

Changes:

This PR addresses the issue with intake issue work log activity validation.

Reference:

[WEB-2186]

Summary by CodeRabbit

• New Features
  • Enhanced issue handling with the addition of a new property to distinguish between intake and non-intake issues in the inbox.
• Bug Fixes
  • Improved rendering behavior of the IssueActivity component based on the classification of issues.

[coderabbitai]

Walkthrough

The recent changes introduce a new boolean prop, isIntakeIssue, to the IssueActivity component within the InboxIssueMainContent. This addition enhances how issues are classified and displayed, particularly distinguishing between intake and non-intake issues. Consequently, the component's flexibility and functionality are improved, allowing for tailored rendering based on issue type while retaining the existing structure and control flow.

Changes

Files	Change Summary
web/core/components/inbox/content/issue-root.tsx	Added isIntakeIssue prop to IssueActivity component invocation in InboxIssueMainContent.
web/core/components/issues/issue-detail/issue-activity/root.tsx	Updated TIssueActivity type definition to include isIntakeIssue?: boolean.

Poem

In the inbox where issues play,
A new toggle brightens the day.
Intake or not, they now can show,
How to handle them, we’ll surely know!
🐰✨ Let’s hop with joy, for changes so spry,
More clarity in tasks as we flutter by!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e805c49 and b3b4e81.

Files selected for processing (2)

• web/core/components/inbox/content/issue-root.tsx (1 hunks)
• web/core/components/issues/issue-detail/issue-activity/root.tsx (3 hunks)

Additional comments not posted (3)

web/core/components/inbox/content/issue-root.tsx (1)

163-163: Ensure correct usage of the isIntakeIssue prop.

The isIntakeIssue prop has been added to the IssueActivity component. Verify that this prop is correctly handled within the component to ensure the intended behavior.

Verification successful

---

Verified: Proper handling of the isIntakeIssue prop in IssueActivity.

The isIntakeIssue prop is correctly used within the IssueActivity component to conditionally render UI elements, ensuring the intended behavior. No further action is needed.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of the `isIntakeIssue` prop in the `IssueActivity` component implementation.

# Test: Search for the `isIntakeIssue` prop usage. Expect: Proper handling of the prop.
rg --type typescript -A 5 $'isIntakeIssue'

Length of output: 76

---

Script:

#!/bin/bash
# Description: Verify the usage of the `isIntakeIssue` prop in the `IssueActivity` component implementation.

# Test: Search for the `isIntakeIssue` prop usage. Expect: Proper handling of the prop.
rg --glob '*.tsx' -A 5 'isIntakeIssue'

Length of output: 2365

web/core/components/issues/issue-detail/issue-activity/root.tsx (2)

24-24: Ensure default handling for isIntakeIssue.

The isIntakeIssue property is optional and defaults to false. Verify that this default behavior aligns with the intended functionality and that it is documented if necessary.

---

118-125: Conditional rendering based on isIntakeIssue looks good.

The logic to conditionally render the IssueActivityWorklogCreateButton based on the isIntakeIssue prop is clear and should work as intended. Ensure that this does not inadvertently affect other functionalities.