[WEB-2222] fix: project modal shortcut

[aaryan610]

Problem:

When opening the create project modal using the P shortcut for the very first time, the project title gets populated with the character p as well.

Solution:

Added the missing logic to prevent default event trigger.

Plane issue: WEB-2222

Summary by CodeRabbit

• New Features

  • Enhanced keyboard shortcut handling in the Command Palette for improved user experience.
  • Updated modal management by integrating a new ModalCore component for the Create Project Modal, simplifying its structure and enhancing configurability.

• Bug Fixes

  • Adjusted event handling to prevent default browser actions during workspace-related shortcuts.

• Style

  • Modified padding in the Create Project Form and Project Create Buttons for better visual spacing.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes across the CommandPalette, CreateProjectForm, and CreateProjectModal components enhance user experience and maintainability. Key modifications include refined keyboard shortcut handling, improved padding for visual consistency, and a structural overhaul of the modal to streamline its functionality. These updates collectively aim to create a more intuitive interface and facilitate easier management of modal interactions within the application.

Changes

Files	Change Summary
web/core/components/command-palette/command-palette.tsx web/core/components/project/create-project-form.tsx web/core/components/project/create-project-modal.tsx	Updates to keyboard shortcut handling in the command palette enhance clarity and user experience. Minor CSS adjustment for padding in the project form. Major structural change in the project modal, replacing previous components with a simpler ModalCore, improving modularity and configurability.
web/core/components/project/create-project-modal.tsx web/core/components/project/create/project-create-buttons.tsx	The modal's structure has been simplified by replacing Dialog and Transition components with ModalCore, while the button group padding was adjusted for better visual balance.

Poem

🐇 In the meadow of code, changes bloom bright,
Modals and palettes, all now feel right.
With shortcuts refined and padding just so,
A smoother experience, watch our projects grow!
Hops of delight in each line that we see,
A joyful dance of code, oh how happy we’ll be! 🥕✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3ffaa4f and 0ff3aef.

Files selected for processing (3)

• web/core/components/command-palette/command-palette.tsx (3 hunks)
• web/core/components/project/create-project-form.tsx (1 hunks)
• web/core/components/project/create-project-modal.tsx (2 hunks)

Files skipped from review due to trivial changes (1)

• web/core/components/project/create-project-form.tsx

Additional comments not posted (2)

web/core/components/project/create-project-modal.tsx (1)

40-52: Modularization improvements are approved.

The use of ModalCore enhances modularity and maintainability. Ensure that the ModalCore component is correctly integrated and functions as expected.

Verify the ModalCore component's integration and usage consistency across the application.

Verification successful

---

Integration of ModalCore is consistent across the application.

The ModalCore component is used in various parts of the application, demonstrating a coherent and well-integrated approach to modularization. This confirms that the refactoring to use ModalCore is effectively implemented.

• Files like web/core/components/project/create-project-modal.tsx, web/ce/components/workspace/upgrade/paid-plans-upgrade-modal.tsx, and others show consistent usage patterns.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the integration and usage of `ModalCore` across the application.

# Test: Search for `ModalCore` usage. Expect: Consistent usage and integration.
rg --type tsx --type jsx 'ModalCore'

Length of output: 64

---

Script:

#!/bin/bash
# Description: Verify the integration and usage of `ModalCore` across the application.

# Test: Search for `ModalCore` usage. Expect: Consistent usage and integration.
rg 'ModalCore' --glob '*.tsx' --glob '*.jsx'

Length of output: 7817

web/core/components/command-palette/command-palette.tsx (1)

271-274: Enhancements to keyboard shortcut handling are approved.

The addition of e.preventDefault() improves user experience by preventing unintended default actions. The logic restructuring enhances clarity.

Verify that the logic restructuring does not introduce any regressions or errors.