[WEB-2133] fix : Remove inbox delete option for members by rahulramesha · Pull Request #5395 · makeplane/plane

rahulramesha · 2024-08-20T15:29:11Z

This PR removes the option for deletion of issues for members if they are not the author of the issue.

Summary by CodeRabbit

New Features
- Enhanced access control for issue deletion, now allowing only users with administrative roles or the issue creator to delete issues.
Bug Fixes
- Improved permission handling ensures that only authorized users can manage issue deletions, enhancing security.

coderabbitai · 2024-08-20T15:29:18Z

Walkthrough

The recent changes refine the permissions for deleting issues in the InboxIssueActionsHeader component. Now, only users with administrative roles or the creators of the issues are allowed to delete them. This enhancement strengthens security and access control, ensuring that only users with the appropriate permissions can manage issue deletions effectively.

Changes

File Path	Change Summary
`web/core/components/inbox/content/inbox-issue-header.tsx`	Updated deletion logic to restrict permissions: only admins (≥ `EUserProjectRoles.ADMIN`) or creators can delete issues.

Poem

🐇 In the inbox where issues dwell,
A new rule sprouted, oh so swell!
Only the wise, with roles so grand,
Can tidy up the cluttered land.
Hooray for control, let’s all cheer,
For a safer space, we hold dear! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f789c72 and a4699d1.

Files selected for processing (1)

web/core/components/inbox/content/inbox-issue-header.tsx (1 hunks)

Additional comments not posted (1)

web/core/components/inbox/content/inbox-issue-header.tsx (1)

86-89: LGTM! Verify the logic implementation across the codebase.

The updated logic for canDelete aligns with the PR objectives and enhances security by restricting deletion permissions to admins and issue creators.

To ensure consistency, verify that this logic is correctly implemented throughout the codebase.

Run the following script to check for similar permission checks:

SatishGandham · 2024-08-21T11:10:05Z

web/core/components/inbox/content/inbox-issue-header.tsx

-  const canDelete = isAllowed || inboxIssue?.created_by === currentUser?.id;
+  // can delete only if admin or is creator of the issue
+  const canDelete =
+    (!!currentProjectRole && currentProjectRole > EUserProjectRoles.MEMBER) ||


NIT: Can you change it to >= admin?

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a4699d1 and db28e4e.

Files selected for processing (1)

web/core/components/inbox/content/inbox-issue-header.tsx (1 hunks)

Files skipped from review as they are similar to previous changes (1)

web/core/components/inbox/content/inbox-issue-header.tsx

remove inbox delete option for members

a4699d1

rahulramesha added 🐛bug Something isn't working 🌐frontend labels Aug 20, 2024

rahulramesha requested a review from SatishGandham August 20, 2024 15:29

coderabbitai bot reviewed Aug 20, 2024

View reviewed changes

SatishGandham approved these changes Aug 21, 2024

View reviewed changes

SatishGandham suggested changes Aug 21, 2024

View reviewed changes

change inbox issue delete condition slightly

db28e4e

coderabbitai bot reviewed Aug 21, 2024

View reviewed changes

SatishGandham approved these changes Aug 21, 2024

View reviewed changes

SatishGandham merged commit 696b134 into preview Aug 21, 2024

SatishGandham deleted the fix-remove-inbox-delete branch August 21, 2024 11:20

coderabbitai bot mentioned this pull request Oct 7, 2024

[WEB-2589] Chore: inbox issue permissions #5763

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WEB-2133] fix : Remove inbox delete option for members#5395

[WEB-2133] fix : Remove inbox delete option for members#5395
SatishGandham merged 2 commits intopreviewfrom
fix-remove-inbox-delete

rahulramesha commented Aug 20, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Aug 20, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

SatishGandham Aug 21, 2024

Uh oh!

coderabbitai bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

rahulramesha commented Aug 20, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Aug 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

SatishGandham Aug 21, 2024

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rahulramesha commented Aug 20, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 20, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)