[WEB-2277] fix: project intake viewer permission validation

[anmolsinghbhatia]

Changes:

This PR fixes the intake issue permission validation. Previously, users with viewer permissions could access the create issue modal, which was not the intended behavior.

Reference:

[WEB-2277]

Media:

Before	After

[coderabbitai]

Walkthrough

The changes introduce user role management into the ProjectInboxHeader component by integrating the useUser hook. This allows for the determination of whether the current user is a viewer. Consequently, the rendering logic for the InboxIssueCreateEditModalRoot component is modified to display conditionally based on the user's role, enhancing access control and ensuring that viewers cannot access certain functionalities.

Changes

File Path	Change Summary
web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/inbox/header.tsx	Improved the ProjectInboxHeader component by adding user role checks. Modified rendering logic for the modal based on user roles.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ProjectInboxHeader
    participant InboxIssueCreateEditModalRoot

    User->>ProjectInboxHeader: Check user role
    ProjectInboxHeader-->>User: Determine if viewer
    alt User is not a viewer
        ProjectInboxHeader->>InboxIssueCreateEditModalRoot: Render modal
    else User is a viewer
        ProjectInboxHeader-->>User: Do not render modal
    end

Loading

Poem

🐰 In the code where bunnies play,
Roles now guard the light of day.
Viewers watch, but cannot roam,
While creators make the inbox home.
Hops of logic, clear and bright,
Access granted, wrongs made right! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ae9267e and 79feee3.

Files selected for processing (1)

• web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/inbox/header.tsx (2 hunks)

Additional comments not posted (3)

web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/inbox/header.tsx (3)

15-15: Import statement for useUser is correctly added.

The addition of the useUser hook is necessary for implementing user role checks.

---

23-30: User role logic is correctly implemented.

The extraction of currentProjectRole and the derivation of isViewer are correctly implemented to determine user permissions.

---

69-69: Conditional rendering logic is correctly implemented.

The component is correctly rendered only if the user is not a viewer, enhancing access control.

[SatishGandham]

Show it to any role that is greater than or equal to guest.