[WEB-2289] fix: email notification settings form validation

[anmolsinghbhatia]

Changes:

This PR resolves the issue with the validation of the email notification checkbox.

Reference:

[WEB-2289]

Summary by CodeRabbit

• Improvements
  • Enhanced the user experience by simplifying the checkbox interaction in the Email Notification Form.
  • Streamlined state management, allowing for a more intuitive checkbox behavior.
  • Adjusted button functionality for improved responsiveness based on user input.

[coderabbitai]

Walkthrough

The changes to the EmailNotificationForm component involve a simplification of form state management. The watch and setValue functions have been removed, affecting how the checkbox for issue_completed operates. The checkbox's indeterminate state has been eliminated, and its onChange handler is now more straightforward. The button's disabled state no longer considers isDirty, streamlining the form's functionality.

Changes

Files	Change Summary
web/core/components/profile/notification/email-notification-form.tsx	Removed watch and setValue from the form state management, simplified checkbox logic and its state handling, and adjusted button's disabled state.

Poem

🐰 In the meadow where the bunnies hop,
A form grew simpler, no need for a stop.
Checkboxes dancing, oh so bright,
With state so clear, everything feels right!
No more fuss, just joy in the air,
Hooray for changes, we leap without care! 🌼✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 460003c and c2486a1.

Files selected for processing (1)

• web/core/components/profile/notification/email-notification-form.tsx (3 hunks)

Additional comments not posted (2)

web/core/components/profile/notification/email-notification-form.tsx (2)

26-26: Simplified form state management looks good.

The removal of watch and setValue simplifies the form state management and aligns with the PR objective of fixing validation. The use of dirtyFields ensures that only changed fields are updated.

---

154-154: Verify the impact of button state management changes.

The button's disabled state no longer checks for isDirty, which may affect when the button is enabled or disabled. Verify that this change does not negatively impact the user experience.

Run the following script to check for any conditions related to isDirty that might affect the button's behavior: