[PWA-1] fix: pwa app sidebar redirection

[anmolsinghbhatia]

Changes:

This PR resolves bugs and implements improvements for the app sidebar in the PWA.

Reference:

[PWA-1] [PWA-8] [PWA-9]

Summary by CodeRabbit

• New Features

  • Enhanced the Favorite Item Title to dynamically react to state changes, improving responsiveness, especially on mobile devices.
  • Integrated routing functionality in Sidebar Projects List Item, allowing seamless navigation to project details when items are clicked.

• Bug Fixes

  • Improved sidebar toggle behavior based on the platform, enhancing user experience on mobile devices.

• Chores

  • Refactored click handling logic for project items to streamline navigation and state management.

[coderabbitai]

Walkthrough

The changes involve refactoring the FavoriteItemTitle and SidebarProjectsListItem components to enhance their reactivity and routing capabilities. The FavoriteItemTitle component is transformed into a MobX observer, integrating new hooks for improved sidebar toggle functionality on mobile. The SidebarProjectsListItem now utilizes Next.js routing for project navigation, with enhanced click handling and state management for better user interactions.

Changes

Files	Change Summary
.../favorite-items/common/favorite-item-title.tsx	Converted FavoriteItemTitle to a MobX observer, added hooks useAppTheme and usePlatformOS, modified sidebar toggle behavior for mobile devices.
.../projects-list-item.tsx	Added useRouter for programmatic navigation, created handleItemClick function to manage project selection and sidebar visibility. Updated click handlers for better code organization.

Poem

🐇 In a world of clicks and swipes,
A sidebar dances, mobile vibes.
With routes that flow like gentle streams,
New hooks and functions weave our dreams!
Hooray for changes, fresh and bright,
Let’s hop along, with pure delight! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 48e9042 and f563d1b.

Files selected for processing (2)

• web/core/components/workspace/sidebar/favorites/favorite-items/common/favorite-item-title.tsx (4 hunks)
• web/core/components/workspace/sidebar/projects-list-item.tsx (5 hunks)

Additional comments not posted (7)

web/core/components/workspace/sidebar/favorites/favorite-items/common/favorite-item-title.tsx (3)

3-6: LGTM! Imports are necessary for the changes.

The added imports for observer, useAppTheme, and usePlatformOS are necessary for the new functionality introduced in the component.

---

16-16: LGTM! Component wrapped with observer for MobX reactivity.

Wrapping the component with observer is appropriate to make it reactive to MobX state changes.

---

31-31: LGTM! Improved mobile experience with conditional sidebar toggle.

The addition of the isMobile condition to toggle the sidebar enhances the user experience on mobile devices.

web/core/components/workspace/sidebar/projects-list-item.tsx (4)

11-11: LGTM! Imports are necessary for the changes.

The added imports for useRouter, useParams, and usePathname are necessary for the new routing functionality.

---

285-294: LGTM! Encapsulated click logic with routing.

The handleItemClick function encapsulates click logic and uses router.push for navigation, which is a good practice for handling routing.

---

Line range hint 352-374: LGTM! Improved readability with encapsulated click logic.

Using the handleItemClick function in onClick handlers improves code readability and maintainability.

---

Line range hint 280-283: LGTM! Correct state management with useEffect.

The useEffect correctly updates the isProjectListOpen state based on the URL, ensuring the project list reflects the current project.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f563d1b and a816dff.

Files selected for processing (1)

• web/core/components/workspace/sidebar/projects-list-item.tsx (6 hunks)

Files skipped from review as they are similar to previous changes (1)

• web/core/components/workspace/sidebar/projects-list-item.tsx