[WEB-2325] fix: Creator unable to delete inbox issue

[rahulramesha]

fix to use the accurate created by while checking if the current user is the creator of the inbox issue, so that they have the permission to delete the issue.

Summary by CodeRabbit

• New Features

  • Enhanced logic for determining user permissions to delete issues, allowing for more accurate control based on issue ownership.

• Bug Fixes

  • Resolved inconsistencies in how issue deletion permissions are evaluated, improving user experience regarding issue management.

[coderabbitai]

Walkthrough

The changes involve a modification to the InboxIssueActionsHeader component's logic for determining if an issue can be deleted. The condition now references issue?.created_by instead of inboxIssue?.created_by, indicating a change in the source of issue data used for deletion permissions. Other functionalities, such as marking issues as declined and status calculations, remain unchanged.

Changes

File Path	Change Summary
web/core/components/inbox/content/inbox-issue-header.tsx	Updated the deletion permission logic to check issue?.created_by instead of inboxIssue?.created_by.

Poem

In the inbox where issues play,
A change was made, hip-hip-hooray!
Now we check with a broader view,
For deletions, the logic's new!
With a hop and a skip, let’s embrace,
This tidy update in our workspace! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 890379b and 2ba9d4e.

Files selected for processing (1)

• web/core/components/inbox/content/inbox-issue-header.tsx (1 hunks)

Additional comments not posted (1)

web/core/components/inbox/content/inbox-issue-header.tsx (1)

88-88: LGTM! But verify the function usage in the codebase.

The change correctly references issue?.created_by instead of inboxIssue?.created_by to determine if the current user is the creator of the inbox issue. This should grant the appropriate permissions to the creator, allowing them to delete their own inbox issues as intended.

The code changes are approved.

Run the following script to verify the function usage: