[WEB-2237] fix: intake issue create/update modal

[anmolsinghbhatia]

Changes:

This PR fixes a bug in the intake create/update modal where users couldn't unselect the start date, due date, or parent once they were selected. I've made the necessary changes to resolve this issue.

Reference:

[WEB-2237]

Summary by CodeRabbit

• New Features

  • Introduced a new interactive CustomMenu for selecting and managing parent issues, improving user experience.
  • Enhanced options for changing or removing parent issues through dedicated menu items.

• Improvements

  • Streamlined date handling logic in the DateDropdown components for better clarity and consistency.

[coderabbitai]

Walkthrough

The changes to the InboxIssueProperties component in issue-properties.tsx focus on enhancing parent issue selection and management. A new CustomMenu component replaces a basic button, providing users with interactive options to change or remove parent issues. Additionally, the logic for handling date selections in DateDropdown components has been refined for improved clarity and consistency.

Changes

File Path	Change Summary
web/core/components/inbox/modals/create-edit-modal/issue-properties.tsx	Introduced CustomMenu for managing parent issues; updated onChange logic in DateDropdown components for clarity.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CustomMenu
    participant ParentIssueHandler

    User->>CustomMenu: Open menu
    CustomMenu->>User: Display options (Change, Remove)
    User->>CustomMenu: Select Change
    CustomMenu->>ParentIssueHandler: Update parent issue
    ParentIssueHandler->>User: Confirm update

    User->>CustomMenu: Select Remove
    CustomMenu->>ParentIssueHandler: Remove parent issue
    ParentIssueHandler->>User: Confirm removal

Loading

Poem

🐰 In the realm of code, where changes bloom,
A menu now dances, dispelling the gloom.
With options to change, or simply let go,
The rabbit hops forth, in the UI's glow.
So here’s to the tweaks, both clever and bright,
A joyful leap forward, in the programming night! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 83ceba3 and f36c1b3.

Files selected for processing (1)

• web/core/components/inbox/modals/create-edit-modal/issue-properties.tsx (4 hunks)

Additional comments not posted (4)

web/core/components/inbox/modals/create-edit-modal/issue-properties.tsx (4)

5-5: LGTM!

The import statement for CustomMenu is correct and necessary.

---

98-98: LGTM!

The updated onChange handler for the start date improves code clarity and ensures consistent data handling.

---

110-110: LGTM!

The updated onChange handler for the due date improves code clarity and ensures consistent data handling.

---

161-197: LGTM! But verify handleData function.

The CustomMenu component enhances the user interface by providing interactive options for managing parent issues. Ensure that the handleData function properly handles empty strings when removing a parent issue.

Run the following script to verify the handleData function: